No, it is not correct. The problem is that your check for whether the element exists or not is wrong. You should check for list, not for list->next.
But that's not so important. What's important is that you did access list->next... and that points to the second element of the list. For list_pop_front, you want the sentinel to point to the second element.
Look up a C++ Reference and learn How To Ask Questions The Smart WayOriginally Posted by Bjarne Stroustrup (2000-10-14)
Ok so I have this:
Code:void print(structlist *list) { list = list -> next //this is to go to the element after the sentinel if (list != NULL) //if the element doesn't exist (we have NULL) we don't print it. { printf(%d, list -> data) } }
Tell me first, is this correct? (to see if I have understood)
Wait wait wait I want to be sure I have understood. Is this correct?It inserts an element in front of the sentinelCode:void list_push_front(struct list *list, struct list *elm){ list = list -> next; list -> data = *elm; }
What that code is doing is replacing the data of the first element of the list (not including the sentinel node) with the data from elm . What it should be doing is setting the node elm to point to the first element of the list, then set the sentinel to point to elm. The node member data should not be modified.
