Thread: Newbie Question

Hello all. I am using VS 2017 Community and trying to learn a little C. I am reading a book, and upon trying some of the samples, I am getting errors. Can anyone point me in the right direction to get past this?

Here is the code:

Code:

#include <iostream>
#include <stdio.h>


#define IN 1 /* inside a word */
#define OUT 0 /* outside a word */
/* count lines, words, and characters in input */
int main()
{
    int c, nl, nw, nc, state;
    state = OUT;
    nl = nw = nc = 0;
    while ((c = getchar()) != EOF) {
        ++nc;
        if (c = ’\n’)
            ++nl;
        if (c = ’ ’ || c = ’\n’ || c = ’\t’)
            state = OUT;
        else if (state == OUT) {
            state = IN;
            ++nw;
        }
    }
    printf("%d %d %d\n", nl, nw, nc);

Here are the errors...

Code:

1>c:\users\mjdaley\source\repos\project9\project9\source.cpp(20): error C3873: '0x2019': this character is not allowed as a first character of an identifier
1>c:\users\mjdaley\source\repos\project9\project9\source.cpp(20): error C2017: illegal escape sequence
1>c:\users\mjdaley\source\repos\project9\project9\source.cpp(20): error C3872: '0x2019': this character is not allowed in an identifier
1>c:\users\mjdaley\source\repos\project9\project9\source.cpp(20): error C2065: '’': undeclared identifier
1>c:\users\mjdaley\source\repos\project9\project9\source.cpp(20): error C2146: syntax error: missing ')' before identifier 'n’'
1>c:\users\mjdaley\source\repos\project9\project9\source.cpp(20): error C2059: syntax error: ')'
1>c:\users\mjdaley\source\repos\project9\project9\source.cpp(20): error C2065: 'n’': undeclared identifier
1>c:\users\mjdaley\source\repos\project9\project9\source.cpp(21): error C2146: syntax error: missing ';' before identifier 'nl'
1>c:\users\mjdaley\source\repos\project9\project9\source.cpp(22): error C3873: '0x2019': this character is not allowed as a first character of an identifier
1>c:\users\mjdaley\source\repos\project9\project9\source.cpp(22): error C2017: illegal escape sequence
1>c:\users\mjdaley\source\repos\project9\project9\source.cpp(22): error C3872: '0x2019': this character is not allowed in an identifier
1>c:\users\mjdaley\source\repos\project9\project9\source.cpp(22): error C2065: '’': undeclared identifier
1>c:\users\mjdaley\source\repos\project9\project9\source.cpp(22): error C2146: syntax error: missing ')' before identifier '’'
1>c:\users\mjdaley\source\repos\project9\project9\source.cpp(22): error C2146: syntax error: missing ';' before identifier 'n’'
1>c:\users\mjdaley\source\repos\project9\project9\source.cpp(22): error C2065: 'n’': undeclared identifier
1>c:\users\mjdaley\source\repos\project9\project9\source.cpp(22): error C2146: syntax error: missing ';' before identifier 't’'
1>c:\users\mjdaley\source\repos\project9\project9\source.cpp(22): error C2059: syntax error: ')'
1>c:\users\mjdaley\source\repos\project9\project9\source.cpp(22): error C2065: 't’': undeclared identifier
1>c:\users\mjdaley\source\repos\project9\project9\source.cpp(23): error C2146: syntax error: missing ';' before identifier 'state'
1>c:\users\mjdaley\source\repos\project9\project9\source.cpp(24): error C2181: illegal else without matching if
1>Done building project "Project9.vcxproj" -- FAILED.

Thank you in advance,

Mike

You're probably mixing up the characters ’ and '. The latter is what you want to use in your code.

Originally Posted by Guest

You're probably mixing up the characters ’ and '. The latter is what you want to use in your code.

Well, I guess that's what Copy/Paste get you... lol


Thank you both so much. So it finally compiled, but the program really doesn't do anything. I can type a sentence and hit Enter, but the cursor just jumps to the next line. I was expecting some info...

Thanks again,

Mike

You are also placing the C code in a .cpp file which triggers g++ NOT a .c file to invoke gcc. Also, remove the iostream include line!

Thank you for that bit of info. I was wondering how to create C from VS 2017. Found a YouTube video that pointed me in the right direction. Although, still no results running the executable. I enter info and hit enter, and all that happens is the cursor jumps to the next line.

Thanks again,

Mike

Originally Posted by parallon

Thank you for that bit of info. I was wondering how to create C from VS 2017. Found a YouTube video that pointed me in the right direction. Although, still no results running the executable. I enter info and hit enter, and all that happens is the cursor jumps to the next line.

Thanks again,

Mike

Can't help you with "VS 2017", as I only use Linux and gcc.

Your code contains 'multi byte characters" that will not compile under gcc.

If you enter a line and press enter it will continue to wait for more data to be entered as you are testing the getchar() against "EOF" NOT '\n, a newline!

Line 17

Code:

 if (c = ’ ’ || c = ’\n’ || c = ’\t’)

Should read:

Code:

 if (c == ’ ’ || c == ’\n’ || c == ’\t’)

And on other lines where you are testing c to be equal to a character constant!

Code:

c = '\n';

is an assignment!

Code:

c == '\n';

is a test for equality!

Common beginner mistake, but is caught with a good compiler such as a current version of gcc.

Please turn on and turn up warning levels to the highest setting!

@laserlight: Here is the current code...

Code:

#include <stdio.h>




#define IN    1
#define OUT    0
int main()
{
    int c, nl, nw, nc, state;


    state = OUT;
    nl = nw = nc = 0;
    while ((c = getchar()) != EOF) {
        ++nc;
        if (c == '\n')
            ++nl;
        if (c == ' ' || c == '\n' || c == '\t')
            state = OUT;
        else if (state == OUT) {
            state = IN;
            ++nw;
        }
    }
    printf("%d %d %d\n", nl, nw, nc);
}

@rstanley: Yeah, I caught that earlier too, thanks to WoodSTokk.

Here is the output when running the code...