Homework

[Audy Naufal]

Hi, I wanna ask about what should I do next to solve this case ?


This is my code that I have made:

#include <stdio.h>#include <stdlib.h>
#include <unistd.h>


int main()
{
	int h,m;
	int D = 1000;
	int numTestCases;
	
	scanf("%d",&numTestCases);
	for ( int i = 1 ; i <= numTestCases ; i++ ) {
    printf("Case #%d:\n", i);
	scanf("%d %d",&h,&m);
	if (h > 12){
		printf("Error!\n"); exit(0);
	}
	if  (m > 60){
		printf("Error!\n"); exit(0);
	}while(1)
	{
		if(h > 12){
			h = 1; m =  0;
		}
		if(m > 59){
			h +=1; m=0;
		}
		printf("\n%02d:%02d",h,m);
		sleep(D);
		system("cls");
		}
	}
}

is there anything that I can add ?

[Salem]

> scanf("%d %d",&h,&m);
How does this correspond to a single integer N between 0 and 1439?

> sleep(D);
Nothing is mentioned in your requirements to actually sleep.

[laserlight]

For starters, you need to indent your code more consistently, e.g.,

#include <stdio.h>
#include <stdlib.h>
#include <unistd.h>
 
 
int main()
{
    int h, m;
    int D = 1000;
    int numTestCases;
     
    scanf("%d", &numTestCases);
    for (int i = 1; i <= numTestCases; i++) {
        printf("Case #%d:\n", i);
        scanf("%d %d", &h, &m);
        if (h > 12) {
            printf("Error!\n"); exit(0);
        }
        if  (m > 60) {
            printf("Error!\n"); exit(0);
        }
        while(1) {
            if (h > 12) {
                h = 1;
                m =  0;
            }
            if (m > 59) {
                h += 1;
                m = 0;
            }
            printf("\n%02d:%02d", h, m);
            sleep(D);
            system("cls");
        }
    }
}

Other comments concerning your code:

• These are poorly named variables:
  

  int h, m;

  You probably should rename them to hours and minutes respectively.
• This is a poorly named variable:
  

  int D = 1000;

  You should declare it to be a constant and give it a descriptive name, e.g.,
  

  const int TEST_CASE_DISPLAY_PAUSE_TIME = 1000;

  Actually, your instructions don't tell you to pause the display and then clear the screen, so I don't know why you want to do this.
• Although it probably isn't necessary, it is good practice to check the return value of scanf just in case it fails, and also to check that indeed the value of numTestCases is in the given range.
• This is obviously wrong:
  

  scanf("%d %d", &h, &m);

  Your instructions say that "Each test case will contain an number N, the number displayed by the strange clock" and this is backed up by the example, so reading two numbers instead of one for each test case is undeniably wrong. Consequently, your input range checking is also wrong.
• You don't need an infinite loop; you should be displaying one output line per test case, so your infinite loop is actually wrong. You don't even need a loop to compute the hours and minutes given the input for the test case.

[Audy Naufal]

I Have my code reevaluated and simplified :

#include <stdio.h>#include <stdlib.h>


int main()
{
    int h,m,N;
    int c;
    
    scanf("%d",&c);
    for(int i=1;i<=c;i++);
    {
        scanf("%d",&N);
        h[i] = N[i]/60;
        m[i] = N[i]%60;
        printf("Case #%d: %02d:%02d\n");
    }
    return 0;
}

This is the simplified code, i hope you can help me with this.
this thing is complaining about:

[Error] invalid types 'int[int]' for array subscript

Please, I need your help

[Salem]

There is no need for any arrays in this problem.

Also, watch the ; at the end of the for loop.