Thread: Code Review Request: Number Histogram

Threaded View

Previous Post Previous Post   Next Post Next Post
  1. #1
    Registered User
    Join Date
    Jun 2018
    Posts
    2

    Code Review Request: Number Histogram

    Hello! I've been wanting to learn C a while now and finally decided to pick up Kernighan and Ritchie's ANSI C. One of the 'projects' is to create a numbered histogram, which I successfully did.

    I just would like to know if this could be further optimized or any other pointers you all may have.

    Thanks!

    Code:
    /* Histogram for counting input of numbers.
       Troy Martin, Beef Erikson Studios 2018 */
    
    
    #include <stdio.h>
    
    
    int main()
    {
        /* forward declares */
        int c, i, j;
        int ndigit[10];
    
    
        /* variable / array assignment */
        int number = 0;
        for (i = 0; i < 10; ++i)
            ndigit[i] = 0;
    
    
        /* reads input and puts numbers into corresponding array index */
        while ((c = getchar()) != EOF)
            if (c >= '0' && c <= '9')
                ++ndigit[c-'0'];
        printf("\n\n");
    
    
        /* finds highest number */
        for (i = 0; i < 10; ++i)
            if (ndigit[i] > number)
                number = ndigit[i];
    
    
        /* display histogram based on highest number */
        for (i = 0; i < number; --number) {
            for (j = 0; j < 10; ++j) {
                if (ndigit[j] >= number)
                    printf("   *");
                else
                    printf("    ");
            }
            printf("\n");
        }
    
    
        /* prints footer */
        for (i = 0; i < 10; ++i)
            printf("%4d", i);
        printf("\n\n  Histogram of times each number was used.\n\n");
    }
    Here it is running:
    Code Review Request: Number Histogram-fnrrbqd-png
    Last edited by beef_erikson; 06-11-2018 at 03:09 PM.

Popular pages Recent additions subscribe to a feed

Similar Threads

  1. Request for code review
    By thelastcylon in forum C++ Programming
    Replies: 4
    Last Post: 02-22-2017, 01:32 PM
  2. problem printing histogram about number frequencies
    By Hana Nasser in forum C Programming
    Replies: 14
    Last Post: 03-17-2015, 02:47 AM
  3. request for C code for factorial of any wish number
    By neverthought in forum C Programming
    Replies: 17
    Last Post: 05-28-2010, 06:27 AM
  4. code review request: stack implementation
    By cs32 in forum C Programming
    Replies: 6
    Last Post: 02-24-2008, 02:26 PM
  5. Request for peer review
    By ruthgrin in forum C++ Programming
    Replies: 13
    Last Post: 01-26-2006, 10:03 PM

Tags for this Thread