Code:#include<string.h> #include<stdio.h> int main() { char s[10]; fgets(s,10,stdin); func(s); return 0; } void func(char a[]) { int i, c1, c2; while(a[i]!='\0') { if((a[i]>=65 && a[i]<=90) || (a[i]>=97 && a[i]<=122)) { if(a[i]=='A' || a[i]=='I' || a[i]=='O' || a[i]=='U'|| a[i]=='E' || a[i]=='a' || a[i]=='i' || a[i]=='o' || a[i]=='u'|| a[i]=='e') { c1++; } else { c2++; } } i++; } printf("Consonants: %d Vowels: %d", c2, c1); }
What are the initial values of i, c1, and c2?
If we initialize c1=0, c2=0;Originally Posted by christop
Still the answer is incorrect for any string that includes one or more blank spaces.
Last edited by sunil9211; 05-01-2018 at 12:02 PM.
You should attempt to answer christop's question, because the answer is the reason for your problem.
If you dance barefoot on the broken glass of undefined behaviour, you've got to expect the occasional cut.
If at first you don't succeed, try writing your phone number on the exam paper.
You're on the right track, but haven't gone quite far enough yet. Uninitialized variables contain whatever garbage is in memory (they aren't zero-ed out when created) and that garbage is causing your program to break. You've got *three* variables.
I agree with you, but ever after initializing the variables it's giving wrong output. Why?
It works for me, so I don't know what you're talking about.
(In other words, if it is "giving wrong output", you should state your input, expected output, actual output, and why you expect that output given that input.)
Look up a C++ Reference and learn How To Ask Questions The Smart Way
It works now. I forgot that function gets() will read only 9 char long string as its size is 10.
Thank you everyone!
