Thread: Calculating Olympic medals

Code:

 

int addcountry(struct medals *as, char *name){
    as->country = malloc(strlen(name)+1);
    if(strcpy(as->country, name) == NULL){
        return 0;
    }
    as->gold = 0;
    as->silver = 0;
    as->bronze = 0;
    return 1;
}
    
void updatemedals(struct medals *as, int size, char *name, int first, int second, int third){
    int i;
    for(i = 0; i < size; i++){
        if(strcmp(as[i].country,name)==0){
        as[i].gold += first;
        as[i].silver += second;
        as[i].bronze += third;
        }
        else{continue;}
    }
}
void printtable(struct medals *as){


    printf("%s %d %d %d\n",as->country, as->gold, as->silver, as->bronze);
    
    
}


int main(){


    struct medals a1;
    char arrays[20];
    char *info = arrays;
    char list[1028];
    int g, s, b;
    int size = 0;
    printf("Enter country and medals");
    char firstletter;
    while(scanf(" %s", list) > 0){
        if(list[0] == 'A'){
            sscanf(list, "%s, %s", &firstletter, info);
            addcountry(&a1, info);
            size++;
        }
        else if(list[0] == 'M'){
            sscanf(list, "%s, %s, %d, %d, %d", &firstletter, info, &g, &s, &b);


            updatemedals(&a1, size, info, g, s, b);
        }
        else if(list[0] == 'L'){
                printtable(&a1);
        }


    }
    return 0;
}

Im doing program that calculates countries medals. First input is for example 'A Canada' which creates new field. And second input is for example 'Canada 1 1 2'. I have probably some mistakes here and I cant find them. My main function is pretty messy so if someone could give some help how to fix main function it would be great.

Code:

while(fgets(list, sizeof(list), stdin) != NULL){
		if(list[0] == 'A'){
			sscanf(list, "%s %*s", &firstletter, info);
			addcountry(&a1, info);
			size++;
		}
		else if(list[0] == 'M'){
			int g, s, b;
			if (sscanf(list, "%s %*s %s %d %d %d", &firstletter, info, &g, &s, &b) ==4){updatemedals(&a1, size, info, g, s, b);}
			else{printf("Failed!");}
		}
		else if(list[0] == 'L'){
				printtable(&a1);
		}


	}
	return 0;
}

I tried to fix but it goes to Segmentation fault and it gives one warning " sscanf(list, "%s %*s", &firstletter, info) ”info” may be used uninitialized in this function -Wmaybe-uninitialized

Users input will be for example: ' A Canada ' (creating new field)
next input: 'M Canada 1 0 0', which will update current medal situation.
I'm beginner so I'm little uncertain what are you saying, but I dont want to ignore any field but I try to do the process in parts; first create then update.

Thanks!
I have also one problem; when I input more than one for example, "A Canada" "A China" "M Canada 1 0 0" "M China 2 1 1", I get some strange output: "Canada 1 0 0" "1962936908 543780207 540024889"
I modified my printfunction to:

Code:

for(int i=0; i<size; i++){
        printf("%s %d %d %d\n",as[i].country, as[i].gold, as[i].silver, as[i].bronze);
    }

How should I do it? I tried few ways but cant do it properly

I did struct medals a1[20] and removed & -signs from function calls