Thread: Heap max and insert sort

Hello again,

I am working on a heap program :)

The code will let the user insert numbers and then print them in order, starting with the largest number. In the end, the heap will be empty once the last number is printed.

My problem is, that the heap is not sorted. The parent is supposed to be greater than the children. People tell me that the swap is not working:

Code:

void heapify(heap* h, size_t i)
{ 
    if (largest != i)
    {
        int tmp = h -> elements[i];
        h -> elements[i] = h -> elements[largest];
        h -> elements[largest] = tmp;
        heapify(h, largest);
    }
}

I feel pretty stupid for not seeing it but I don't know what I am doing wrong in this section.

Also, it doesn't print the largest number. That would be this section:

Code:

int heap_extract_max(heap* h) 
{
    int max;
    if (h -> size < 1)
    {
        printf("Heap is empty!\n");
        return(-1);
    }
    else
    {
        max = h -> elements[0];
        h -> elements[0] = h -> elements[h -> size[h -> elements]];
        h -> size[h -> elements] = h -> size - 1;
        heapify(h, 0);
        return max;
    }
}

I am happy about any kind of help! :)
Feel free to ask me about other parts of the code. I didn't want to post the whole code so I tried to minimize it on the problems but as a newbie I could be wrong of course.

I am honestly not good enough to just write a minimal program with the same error.
You mean, you need more of the code? Probably even the whole code?
I know for sure that the problem is in my extract_max function, I thought it was enough to post it :/

I was reading the website that you linked and I feel like it's impossible for me to do this. I was given lots of code but I only have to implement the few functions. The other functions, which were already given, are functions that I cannot understand yet with my level of knowledge. I can't just delete something in there because I don't know what they are doing.... it's like twenty pages of code so I tried to stick to my own functions.
Everything would be much easier for me if I could just write my own code from the beginning.

You mean this?

Code:

struct heap {
    int* elements;
    size_t size;
    size_t capacity;
};