Thread: Problem in program

I want to print Characters 'X','Y','Z' in reverse way 'Z','Y','X'

Code:

#include <stdio.h>


int main(void)
{
    char charcters[3] = {'X','Y','Z'}; 
	
	unsigned int index;
	
	for (index =0; index < 3; index++)
	{
		printf("Characters  %c \n", charcters[index]);
		
	}
	
	for (index =3; index > 0; index--)
	{
		printf("Characters in reverse way %c \n", charcters[index]);
		
	}
    
	return 0;
}

Characters X
Characters Y
Characters Z

Characters in reverse way 
Characters in reverse way Z
Characters in reverse way Y

Originally Posted by Salem

Also print the value of index in both loops.

Then you will see you're off by 1 when counting backwards.

I did it

Code:

#include <stdio.h> 
 int main(void)
{
	char charcters[3] = {'X','Y','Z'}; 
	int index;
	for (index = 0; index < 3; index++)
	{
		printf(" Characters  %d = %c \n",index, charcters[index]);
	}
	
	for (index = 2; index >= 0; index--)
	{
		printf(" reverse way %d = %c \n",index,charcters[index]);
	}
    return 0;
}

Characters 0 = X
Characters 1 = Y
Characters 2 = Z

reverse way 2 = Z
reverse way 1 = Y
reverse way 0 = X

Program to find maximum number in three numbers

Code:

#include <stdio.h>

int main(void)
{
    int a = 25;
	int b = 35;
	int c = 15;
	int maximum;
	
	maximum = 25;
    
    if (maximum < b)
	{
		maximum = a;
	}
	if (maximum < c)
	{
	    maximum = c;
	}
	printf("\n maximum number %d ", maximum);
	
	return 0;
}

maximum number 25

Is there any mistake ?

Originally Posted by stahta01

Yes.

There is also a worse second mistake; I did not look for a third mistake.

Tim S.

What is that ?

Originally Posted by stahta01

Do your own homework!!
If you tried running the program then the problem would be clear.

Tim S.

I have run program and result already posted. By the way this is not homework. I asked to improve program writing style. this program is written by me

Easiest is to write a function to determine the max of two values, like so:

Code:

int max_val(int a, int b)
{
  /* return your result here */
}

int main()
{
  int a = 5, b = 7, c = 2;
  
  int d = max_val(max_val(a, b), max_val(a,c));

  printf("%d", d);

}

Originally Posted by stahta01

Now where in the code is the max value set to the value of "b"?
Answer, never.

Tim S.

Thank you very much.

Code:

#include<stdio.h>

int main (void)
{
	int a =25; 
	int b=35; 
	int c=15; 
	int maximum = a;
     
    if (maximum < b)
    {
        maximum = b;
    }
    if (maximum < c)
    {
        maximum = c;
    }
    printf("\n maximum number %d ", maximum);
     
    return 0;
}

maximum number 35