Sorting a struct array(numerical+alphabetical)

**emano12** · 01-23-2018

(C programming)I have been trying for the past hours to sort a struct array with 10 elements. However I did not understand much at the sites where I looked for more information. Can anyone solve this, or at least give me a start.

Here is an example from the textfile im using:

82476,Watermelon Dorado Double India Pale Ale,31.90,355.00,Ale brittisk-amerikansk stil,Imperial/Dubbel IPA,Flaska,USA,Ballast Point Brewing,10.00

And here is my code:

Code:

void listanr(void)
    
    {


        char *oneline, *tok;
        char envara[512];
        char delim[] = ",";
        FILE *fp;
        int i;




        struct vara
        {
            int nummer;
            char namn[100];
            float pris;
            float volym;
            char typ[100];
            char stil[100];
            char forpackning[20];
            char land[20];
            char producent[50];
            float alkoholhalt;


        } items[100];




        if ((fp = fopen("varor.csv", "r")) == NULL)
        {
            fprintf(stderr, "Filen varor.csv gick inte att öppna\n");
            exit(-1);
        }


        for (i = 0; i < 100 && fgets(envara, 512, fp); i++)
        {
            envara[strlen(envara) - 1] = '\0';
            oneline = strdup(envara);


            tok = strtok(oneline, delim);
            items[i].nummer = atoi(tok);
            tok = strtok(NULL, delim);
            strncpy(items[i].namn, tok, (max(strlen(tok), sizeof(items[0].namn))));
            tok = strtok(NULL, delim);
            items[i].pris = atof(tok);
            tok = strtok(NULL, delim);
            items[i].volym = atof(tok);
            tok = strtok(NULL, delim);
            strncpy(items[i].typ, tok, strlen(tok));
            tok = strtok(NULL, delim);
            strncpy(items[i].stil, tok, strlen(tok));
            tok = strtok(NULL, delim);
            strncpy(items[i].forpackning, tok, strlen(tok));
            tok = strtok(NULL, delim);
            strncpy(items[i].land, tok, min(strlen(tok), sizeof(items->land)));
            tok = strtok(NULL, delim);
            strncpy(items[i].producent, tok, strlen(tok));
            tok = strtok(NULL, delim);
            items[i].alkoholhalt = atof(tok);


            printf("nummer: %d\n"
                "namn: %s\n"
                "pris: %f\n"
                "volym: %f\n"
                "typ: %s\n"
                "stil: %s\n"
                "forpackning: %s\n"
                "land: %s\n"
                "producent: %s\n"
                "alkoholhalt: %f\n\n",
                items[i].nummer,
                items[i].namn,
                items[i].pris,
                items[i].volym,
                items[i].typ,
                items[i].stil,
                items[i].forpackning,
                items[i].land,
                items[i].producent,
                items[i].alkoholhalt
);


      


            free(oneline);
        }


        fclose(fp);
    }

**laserlight** · 01-23-2018

How would you sort an int array with 10 elements?

**jimblumberg** · 01-23-2018

Also posted here and here.

**Salem** · 01-23-2018

Some points to ponder.

1. atoi/atof return 0 on error, which isn't exactly useful. Use strtod etc, where you can check for errno to determine success.

2. It's a waste of time calling strdup(), when you can just as easily strtok the original buffer.

3. None of your strncpy calls is correct.
Where you do bother to call min(), you don't allow space for the \0 if the initial string doesn't fit. Strncpy() will not append a \0 for you if there isn't a \0 in the copied part of the input string.

**OldGuy2** · 01-23-2018

To sort your array you can use qsort:
C library function - qsort()

What are actually the criteria to sort ?

**emano12** · 01-24-2018

I´m supposed to store the data in 1. numerical order(based on "nummer")
and 2. alphabetical order(based on "namn")

the program I have for the moment is working just fine, just having a hardtime getting started with the sorting.

**OldGuy2** · 01-24-2018

Here is a little demo to sort structs:

Code:

#include <stdio.h>
#include <string.h>
#include <stdlib.h>

typedef struct
{
  char name[25];
  int age;
}TPerson;

TPerson People[] = 
{
  {"Lisa", 33},
  {"Anna", 22},
  {"Debbie", 44}
};

#define NUM_PEOPLE sizeof(People) / sizeof(People[0])

int age_sorter(const void* p1, const void* p2)
{
  TPerson *person1 = p1;
  TPerson *person2 = p2;

  return person1->age - person2->age;
}

int name_sorter(const void* p1, const void* p2)
{
  TPerson *person1 = p1;
  TPerson *person2 = p2;

  return strcmp(person1->name, person2->name);
}

int main()
{
  int i;

  printf("People sorted by name:");
  qsort(People, NUM_PEOPLE, sizeof(TPerson), name_sorter);
  for (i = 0; i <NUM_PEOPLE; i++)
    printf("\n%s\t%d", People[i].name, People[i].age);

  printf("\n\nPeople sorted by age:");
  qsort(People, NUM_PEOPLE, sizeof(TPerson), age_sorter);
  for (i = 0; i <NUM_PEOPLE; i++)
    printf("\n%s\t%d", People[i].name, People[i].age);
}

**emano12** · 01-25-2018

thank you Oldguy2! really helped

**emano12** · 01-25-2018

This is a sample from my code. I have applied some of your example code to my program. However i have been trying to understand what to input where I wrote "XXXX" in my sorting alghoritm. Any ideas? Am i doing something or right or is it all wrong. The only error that occurs is "XXXX" is undeclared, but i can not figure out the right input.

Code:

#define NUM_ITEMS sizeof(items) / sizeof(items[0])

struct vara
        {
            int nummer;
            char namn[100];
            float pris;
            float volym;
            char typ[100];
            char stil[100];
            char forpackning[20];
            char land[20];
            char producent[50];
            float alkoholhalt;


        } items[100];

for (i = 0; i < 100 && fgets(envara, 512, fp); i++)
        {
            envara[strlen(envara) - 1] = '\0';
            oneline = strdup(envara);


            tok = strtok(oneline, delim);
            items[i].nummer = atoi(tok);
            tok = strtok(NULL, delim);
            strncpy(items[i].namn, tok, (max(strlen(tok), sizeof(items[0].namn))));
            tok = strtok(NULL, delim);
            items[i].pris = atof(tok);
            tok = strtok(NULL, delim);
            items[i].volym = atof(tok);
            tok = strtok(NULL, delim);
            strncpy(items[i].typ, tok, strlen(tok));
            tok = strtok(NULL, delim);
            strncpy(items[i].stil, tok, strlen(tok));
            tok = strtok(NULL, delim);
            strncpy(items[i].forpackning, tok, strlen(tok));
            tok = strtok(NULL, delim);
            strncpy(items[i].land, tok, min(strlen(tok), sizeof(items->land)));
            tok = strtok(NULL, delim);
            strncpy(items[i].producent, tok, strlen(tok));
            tok = strtok(NULL, delim);
            items[i].alkoholhalt = atof(tok);


            int nummer_sortering(const void* n1, const void* n2)
            {
                items *XXXX = n1;
                items *XXXX = n2;


                return items->nummer - items->nummer;
            }


            printf("\n\nItems sorted by number:");
            qsort(items, NUM_ITEMS, sizeof(items), nummer_sortering);
            for (i = 0; i < NUM_ITEMS; i++)
                printf("nummer: %d\n"
                    "namn: %s\n"
                    "pris: %f\n"
                    "volym: %f\n"
                    "typ: %s\n"
                    "stil: %s\n"
                    "forpackning: %s\n"
                    "land: %s\n"
                    "producent: %s\n"
                    "alkoholhalt: %f\n\n",
                    items[i].nummer,
                    items[i].namn,
                    items[i].pris,
                    items[i].volym,
                    items[i].typ,
                    items[i].stil,
                    items[i].forpackning,
                    items[i].land,
                    items[i].producent,
                    items[i].alkoholhalt);

**stahta01** · 01-25-2018

Code:

items *XXXX;

For XXXX to be declared as an variable you need to use an typename in front of it. "items" is an arrayname.

Tim S.

**stahta01** · 01-25-2018

I strongly warn you that using the "qsort" function without your instructor permission will likely get your project marked with a failing grade.

Tim S.

**emano12** · 01-27-2018

It is ok to use qsort! I have changed my code to this instead, it shows no error but crashes when im trying to run it.

Code:

int nummer_sortering(const void* n1, const void* n2)
			{


				const struct vara *item1 = n1;
				const struct vara *item2 = n2;


				return item1->nummer - item2->nummer;
			}

printf("\n\nVaror sorterade på varunummer:");
			qsort(items, NUM_ITEMS, sizeof(items), nummer_sortering);
			for (i = 0; i < NUM_ITEMS; i++)
			{


				printf("nummer: %d\n"
					"namn: %s\n"
					"pris: %f\n"
					"volym: %f\n"
					"typ: %s\n"
					"stil: %s\n"
					"forpackning: %s\n"
					"land: %s\n"
					"producent: %s\n"
					"alkoholhalt: %f\n\n",
					items[i].nummer,
					items[i].namn,
					items[i].pris,
					items[i].volym,
					items[i].typ,
					items[i].stil,
					items[i].forpackning,
					items[i].land,
					items[i].producent,
					items[i].alkoholhalt);
			}

**stahta01** · 01-27-2018

qsort(3): sort array - Linux man page

The qsort() function sorts an array with nmemb elements of size size. The base argument points to the start of the array.

Code:

qsort(items, NUM_ITEMS, sizeof(items), nummer_sortering);

NUM_ITEMS is likely wrong.

sizeof(items) is wrong.

Tim S

**emano12** · 01-28-2018

Thank you for the response. How could I solve it? Tried with "vara" but didnt work.

**stahta01** · 01-28-2018

Originally Posted by emano12

Thank you for the response. How could I solve it? Tried with "vara" but didnt work.

You fix it by reading about qsort and then fixing your code.

Tim S.

Thread: Sorting a struct array(numerical+alphabetical)

Thread Tools

Search Thread

Display

Sorting a struct array(numerical+alphabetical)

almost there, i hope

crash

Similar Threads

Sorting array of struct inside struct

Alphabetical sorting in a character array?

C++ Alphabetical sorting, etc Help

Alphabetical sorting function

Sorting in alphabetical order

Tags for this Thread