I want to find largest number form three number
ResultCode:#include <stdio.h> int main(void) { int a, b, c, max; max = a; printf(" enter three numbers \n "); scanf(" %d %d %d ",&a,&b,&c); if(max < b) { max = b; } else if(max < c) { max = c; } printf("\n largest %d ",max); return 0; }
enter three numbers
5
6
9
8
largest 2965504
What's the wrong in program ?
You assigned a to max before a was entered in.
else if is also probably wrong here, if max is actually less than b then max is assigned b and c is never compared. Instead, compare two numbers, and then compare the third to the largest of the first comparison.
Also the white space you put into a scanf() does matter, try the "%d %d %d" string, so that you don't have to type something random.
Last edited by whiteflags; 12-04-2017 at 11:25 PM.
I have tried to print the value of max but there is error
hello.c: In function 'main':
hello.c:11:4: error: stray '\302' in program
A max = a;
^
hello.c:11:5: error: stray '\240' in program
A max = a;
^
Code:#include "stdio.h" int main(void) { int a,b,c,max; printf("Please input an integer value: "); scanf("%d", &a); printf("Please input an integer value: "); scanf("%d", &b); printf("Please input an integer value: "); scanf("%d", &c); max = a; printf("print max %d \n", max); return 0; }
Do you write code in your word processor? These strange numbered characters usually come from copying code from elsewhere and pasting it into your editor. Either way you need to remove those characters before continuing.
The original program was fine, by the way, I only recommended small changes.
Originally Posted by whiteflags
I write programs in Notepad++. after that I check the program using command promote. I had already made some programs. I copy and paste them to make a new program because it take less time. I do not have to type repeatedly
Last edited by vead; 12-05-2017 at 01:05 AM.
Ah luckily notepad++ is something I know a thing or two about.
Either way, notepad should be able to show you the strange characters so that you can remove them. It was not meant as an affront to you, it is just a thing that can happen from copying and pasting to different programs.I copy and paste them to make a new program because it take less time. I do not have to type repeatedly
Try View -> Show Symbol -> Show all characters
If you see anything that isn't normal line endings or spaces, remove it.
this does not fully work. It is not suppose to. It is to only help give another point of view on some logic that might help to figure this out. So do not completely rely on this code because I took some out, so just apply the Proper logic instead using process of elimination. Where ? is the var holding the max value if true.
if one is bigger then the other two then that is the largest number, so how would you check one unknown number against two other unknown numbers to find the largest number?Code:#include <stdio.h> int main (void) { int a = 0, b = 0, c = 0, max = 0; printf("enter three whole numbers\n"); scanf(" %d%d%d", &a,&b,&c); if ( /* some value checks go here */ ) max = ?; else if ( /* some value checks go here */ ) max = ?; else if ( /* some value checks go here */ ) max = ?; printf("max number is %d\n" "out of these three\n" "a %d, b %d c %d\n", max, a,b,c); return 0; }
This code is in lue of using an array and a loop to do it. As it looks like that is what your are working on. Not using an array and loop to find largest number.
( it is not that much to type, so why copy paste? but yeah you got a watch out for that copy paste and getting hidden formatting codes in text when you do that).
Last edited by userxbw; 12-05-2017 at 10:25 AM.
What he had before was fine, like I keep saying.
max is correct after this. As I said before, I only recommended small changes.Code:max = a; if(max < b) { max = b; } if(max < c) { max = c; }
yeah I can see how that works too,
slight adjustment
Code:scanf(" %d%d%d", &max,&a,&b); //max = a; if(max < a) { max = a; } if(max < b) { max = b; }
