I/O Program not printing variable name
Hi! I am new to the C programming language and have only programmed in C++ and Java before.
And I don't really know how to fix this error that probably is really simple to fix. The problem is that when I input my name and age the program will only print the age and not my name.
Code:#include <stdio.h> int main() { char name[] = ""; printf("State your name: "); scanf("%s", name); short age = 0; printf("Age: "); scanf("%d", &age); printf("Hello %s you are %d years old", name, age); return 0; }
it's a short not an int
outputCode:scanf("%hd", &age);
Code:userx@slackwhere:~/bin $ ./print_vrs State your name: bob Age: 99 Hello bob you are 99 years old
Oh, okay. I though %d was for "short" also. That makes sense why it didn't work. Thank you!
What does %hd stand for by the way?
basically its a short h, int d
short int hd
Format Codes for printf
> char name[] = "";
You also need to allocate some space for the name as well.
Say
char name[50] = "";
If you dance barefoot on the broken glass of undefined behaviour, you've got to expect the occasional cut.
If at first you don't succeed, try writing your phone number on the exam paper.
If you do allocate 50 characters for name, it means that the length of the string would be at most 49 characters because of the terminating null character, so you should amend your scanf call to include this, otherwise it is vulnerable to buffer overflow:
When you have these working, another thing you can look into is checking the return value of scanf, i.e., to check that input was correctly read.Code:scanf("%49s", name);
Look up a C++ Reference and learn How To Ask Questions The Smart WayOriginally Posted by Bjarne Stroustrup (2000-10-14)
It may be that you thought this because you had seen printf("%d", age) be used for data types such as short or unsigned char. This is okay providing that you don't have values which lie outside the range of int. You are only telling it how to format printed text. When you use scanf however you are telling it how to save data, so you must match the format to the data type.Oh, okay. I though %d was for "short" also.
It might also be better practice to use both format specifiers and corrisponding variables in your printf's. Your use of printf doesn't exactly expose security vulnerabilities if you write a string literal right into the printf, but this kind of thinking may at some point lead you to write code that does. I debated on whether to mention this since it isn't really harming anything, but if you are aware of Uncontrolled Format String vulnerabilities, that's cool. In other words printf("%s", "text") is better than printf("text"). Also consider puts("text").
Last edited by jack jordan; 10-28-2017 at 01:04 AM.
