Help C free char** array

**chis.adrian** · 10-27-2017

Hi I need help optimizing this code:

Code:

void free_fields(char** array, int count)
{
     SendMessage(statusBAR, SB_SETTEXT, 1,(LPARAM)"Freeing Memory");
    int i ;
	if (count>0)
	{
		for (i = 0; i<count; i++ )  {


         if  (array!=NULL)  free( array[i] );
		}
	  if  (array!=NULL) free( array );
	}
	//MessageBox(NULL,"Free","Free",MB_OK | MB_ICONERROR);
}

It is working but with big data its slow ;
Compiler TDM-GCC-64 -> x86_64-w64-mingw32-gcc.exe
Same code with Pelles C its much faster but sometimes crash the application
Thank You.

**GReaper** · 10-27-2017

Well, you could move that if statement outside the for loop, there's no need to keep checking it after each and every iteration, just check it once at the beginning and if NULL, skip the loop entirely. Also, are you sure you didn't mean to check the individual element's pointer instead of the whole thing?

Code:

if  (array[i]!=NULL)  free( array[i] );

**chis.adrian** · 10-27-2017

Thank you
Goes a little faster (still not instant but with ~300000 rows/ 6 columns I guess it takes some time to free )
I guess I was confused because I started Project
in Pelles C than switched to Code::Blocks .
Pelles C gives application crashes even when compiles OK.
Btw : Its WinAPI Virtual List with data from Sqlite.

**GReaper** · 10-27-2017

You know, there's another way to minimize overhead. You could omit the free_fields() function and instead modify your alloc_fields() or whatever function to use realloc instead. Free extra memory only on demand (when the array shrinks) instead of every single time.

Here of course I assume that you call it multiple times, which may not be the case.

**chis.adrian** · 10-27-2017

I will give it a try;
Thank You.

Thread: Help C free char** array

Thread Tools

Search Thread

Display

Help C free char** array

Similar Threads

How to fill char array with bit values based on another char array.

int --> char, 2 ints in einem char array zusammenfügen, char array länge bestimmen

English version int-->char,2 ints add to a char array, find the length of char array

Why return malloc'd char array not work, but local char array does?

Initializing char arrays on the free store

Tags for this Thread