Error checking for is number?

[userxbw]

off the command line (Linux) when entering a number with an 's' or 'm' if someone mishaps and puts something like this in.

int seconds_or_minutes(char *what_is_it)
{
  printf("%s\n",what_is_it);
    const char sec = 's';
    const char min = 'm';
    char str1[1+strlen(what_is_it)];

    strcpy(str1, what_is_it);

    if ( strrchr(what_is_it, sec) )
    {
        return (atoi( strtok(str1, "s") ));
    }
    if( strrchr(what_is_it, min) )
    {
        return (atoi(strtok(str1,"m")) * 60);
    }
    if (isdigit(what_is_it))
    {
        printf("is not a number\n");
        exit(1);
    }
    printf("%s",what_is_it);
    //defaults to seconds
    return atoi(what_is_it);
}

This function is to get secs or minutes via a token 's', or 'm' if not either it will default to seconds. But if fat fingers Freddy obvious hits a wrong key and hits a char first. isdigit is not working, or am I applying this wrong?



Note:
the default settings print out (in next code block) is showing it is going to the function call to set for default time setting when the -z is not used to by pass it. that function checks for zero on the var holding the value. if true set to

#ifndef DEFAULT_TIME
#define DEFAULT_TIME (5 * 60)
#endif // DEFAULT_TIME

Using the -z option

userx@slackwhere\⚡/media/data/C-Projects/mhsetroot/mhsetroot/bin/Debug \⚡\ >

./mhsetroot -over-ride   -z f3m  /media/data/wallpaper
f3m
0
defaults time settings

as it does not stop the mishaps it sets to zero (0) then gets set to the main default time settings no matter what. How do I get it to stop from running because of mishaps like this?

Thanks

[Salem]

Well what_is_it is a char pointer.
what_is_it[0] is the first char.
isdigit(what_is_it[0]) would test the first char.

[userxbw]

Well what_is_it is a char pointer.
what_is_it[0] is the first char.
isdigit(what_is_it[0]) would test the first char.

nope didn't work:

dia/data/wallpaper
main 1
seconds or minutes in comming w3m
in getopts 0 // comes back zero

change time 300 // gets set to function calling to set default

int seconds_or_minutes(char *what_is_it)
{
 printf("seconds or minutes in comming %s\n",what_is_it);
    const char sec = 's';
    const char min = 'm';
    char str1[1+strlen(what_is_it)];

    strcpy(str1, what_is_it);
     if (isdigit(what_is_it[0]))
    {
        printf("is not a number\n");
        exit(1);
    }

    if ( strrchr(what_is_it, sec) )
    {
        return (atoi( strtok(str1, "s") ));
    }
    if( strrchr(what_is_it, min) )
    {
        return (atoi(strtok(str1,"m")) * 60);
    }


    printf(" seconds or minutes outgoing not return %s\n",what_is_it);

    //defaults to seconds
    return atoi(what_is_it);
}

this worked though

  if (isdigit(what_is_it[1]))
    {
        printf("is not a number %s\n",what_is_it);
        exit(1);
    }

results

main 1
seconds or minutes in comming w3m
is not a number w3m <-- caught it

[userxbw]

Well what_is_it is a char pointer.
what_is_it[0] is the first char.
isdigit(what_is_it[0]) would test the first char.

what I posted earlier is not up yet, but it is still not correct.
isdigit(what_is_it[0])
did'dent work
the isdigit(what_is_it[1])
and only works 1/2 time no good, nope.

[Salem]

Well you need a better approach if you expect to pick apart garbage input from the user.

3
w3m
3m

[userxbw]

Well you need a better approach if you expect to pick apart garbage input from the user.

3
w3m
3m

yeah, I'm a bit of a perfectionist about somethings.

So I read on line that a char *var is just a zero based array of character(s) first letter is 0, second letter 1, so on and so fourth. but it see here it is not, 0 = the entire word (string).

using [1] to check, on two different means of typing it, wrong and right.

> ./mhsetroot -t n -z s1m /media/data/wallpaper
what is it[0] s1m
what is it[1] 1m
what is it[0] 115
what is it[1] 49
is not a proper format s1m
check opts

> ./mhsetroot -t n -z 11m /media/data/wallpaper
what is it[0] 11m
what is it[1] 1m
what is it[0] 49
what is it[1] 49
is not a proper format 11m
check opts

using [0] to check, same

./mhsetroot -t n -z s1m /media/data/wallpaper
what is it[0] s1m
what is it[1] 1m
what is it[0] 115
what is it[1] 49
check opts
 
  > ./mhsetroot -t n -z 11m /media/data/wallpaper
what is it[0] 11m
what is it[1] 1m
what is it[0] 49
what is it[1] 49
is not a proper format 11m
check opts

where the zero element is the entire string, and it looks like their is no way to actually check the first letter(char) of a string using this method.

and none of this hair ball stuff I just read online works either, along with whatever else I just over wrote,

   char fst; // = strdup(what_is_it);
    fst = what_is_it[0];
    printf("fst %d\n", fst);
    printf("fst  %s\n", &fst);
    //if (isdigit(what_is_it[0]))
    if (isdigit(fst))

by the way that reads it is backwards to what I have been reading that it stores each single letter in an element separately, from what I have read and seen the examples showing this,

char *str = "noway"
str[0] == n
srt[1] == o
str[2] == w
etc...

this is in no way is the truth.

doesn't fegts or gets chomp off one character at a time?

[Salem]

So is "s1m" valid or not?

Is anything other than this valid?
[0-9]+(s|m)?

That is, 1 or more digits with an optional 's' or 'm' following.

[userxbw]

So is "s1m" valid or not?

Is anything other than this valid?
[0-9]+(s|m)?

That is, 1 or more digits with an optional 's' or 'm' following.

the format is num+indicator | num & ! indicator

but as pointed out I was being overly picky with fat finger syndrome.
I ended up with this if only a 's' or 'm'

int seconds_or_minutes(char *what_is_it)
{
    const char sec = 's';
    const char min = 'm';
    char str1[1+strlen(what_is_it)];

    strcpy(str1, what_is_it);
    // if only s or m is present then return -1
    if ( ( ( strrchr(what_is_it, sec) != NULL ) || (strrchr(what_is_it, min) != NULL) ) && strlen(what_is_it) == 1)
    {
        return -1;
    }
    else if ( strrchr(what_is_it, sec) )
    {
        return (atoi( strtok(str1, "s") ));
    }
    else if( strrchr(what_is_it, min) )
    {
        return (atoi(strtok(str1,"m")) * 60);
    }//defaults to seconds

    return atoi(what_is_it);
}

Imputation

   case 'z': //sets timer time
            if (optarg == NULL)
                printf("< %s >\n",optarg);
            else
                if (seconds_or_minutes(optarg) != -1)
                {
                    opts.ch_t = seconds_or_minutes(optarg);

                }
                else
                {
                    set_oops_color();

                    warning_message();
                }
            break;