error trapping

[John Roble]

bool checkPalindrome(char* inputString) {
    char *start, *end;
    int i, length, counter = 0;
    
    start = inputString;
    end = inputString;
    
    length = stringLength(inputString);
    for(i=0;i<length-1;i++) {
        end++;
    }
    
    if(length<1) {
        return true;
    }




        if(*start==*end) {
            return true;
            }
        else {
            return false;
            }


         
} 
           


int stringLength(char* String) {
    int i, counter=0;
    for(i=0;*(String+i)!='\0';i++) {
        counter++;
    }
    return counter;
}

so basically my program fails with the ff test cases can anyone help me?

[Salem]

You only check the first and last character.

You need to check each pair until you meet in the middle.

[John Roble]

yes, but i dont know how can you give me clue? i have this idea to decrement the address of end and compare the value of it to the value of start i tried different for loops still didnt get it

[John Roble]

You only check the first and last character.

You need to check each pair until you meet in the middle.

solved it by adding these codes but i know this is very impractical

if(length<1) {
        return true;
    }
        if(*start==*end) {
            start++;
            end--; 
            }
            if(*start==*end) {
                start++;
                end--; 
                }
                    if(*start==*end) {
                        start++;
                        end--;
                        
                        }
                        if(*start==*end) {
                            start++;
                            end--;
                            return true;
                        }

[GReaper]

Maybe you should use a loop. Just maybe...

[OldGuy2]

Here is a other way to do it:

bool isPalindrome(char * input)
{
  int len = strlen(input);
  if (input == NULL ||  len == 0)
    return false;

  int first = 0, last = len - 1;

  while (first < last)
  {
    if (input[first] != input[last])
      return false;

    first++;
    last--;
  }

  return true;
}

[John Roble]

Here is a other way to do it:

bool isPalindrome(char * input)
{
  int len = strlen(input);
  if (input == NULL ||  len == 0)
    return false;

  int first = 0, last = len - 1;

  while (first < last)
  {
    if (input[first] != input[last])
      return false;

    first++;
    last--;
  }

  return true;
}

gee, thanks i just learned about memory and i would like to apply it never thought this problem would be that simple