Thread: printing to an array from file

> while(!feof(map)){

Let me beat Salem to the punch...

'feof' is a Bad Thing(TM).

Code:

for(x=0; x < 20; x++){            
            for(y=0; y < 20; y++){                
                array[x][y] = fgetc(map);
                y++;
            }
            x++;

But there is your problem. You are incrementing 'x' and 'y' twice. Stopit. Remove the single 'x++;' and 'y++;' lines.

Quzah.

Your still using feof() ? Stop stop stop it...

Code:

#include <stdio.h>

int main(void)
{
	char array[20][20];
	int c;
	FILE *fp;
	
	if ((fp = fopen("test.txt", "r")) == NULL)
	{
		perror("test.txt");
		return (1);
	}
	
	while ((c = fgetc(fp)) != EOF)
	{
		if (c != '\n')
		{
			putchar (c);
			// add c to the array or whatever you want
		}
	}
	
	fclose(fp);
	return (0);
}

This is just an example of how to read chars from a file. Note that c is defined as an int not a char. This is done to allow us to use the return code from fgetc() in a test against EOF.

Also note, fgetc() will give you the newline characters, so you have to deal with them specially.

Lastly, if you are looking to store the numbers from the file as numbers in the program,
-EG 7 in file being equivalent to int i = 7; in the program
you'll need to do some conversion, as 7 in the file is an ASCII character 7, not a numeric 7. Research atoi() for this.

Happy coding......

whats wrong with feof ????

or shall i do a search ?????

feof() only knows you're at the end of the file when you have performed a read and failed. In the first sample code (using feof()), the loop always stores values in the array after doing a read. It will do this even we it gets EOF. It then checks feof(), but by then it's too late.