printf in Else statement at the end is printing, even if condition in if is false.

[Pranay Rawat]

insert

// Program for searching 1-d array.
#include<stdio.h>
void main()
{
 int i,a[60],val,find;
 clrscr();
 for(i=0;i<5;i=i+1)
 {
  printf("\nenter value of index[%d]:",i);
  scanf("%d",&a[i]);
 }
 for(i=0;i<5;i=i+1)
 {
  printf("\nvalue of array a[%d]:%d",i,a[i]);
 }
 printf("\nEnter value to search:");
 scanf("%d",&val);
 for(i=0;i<5;i=i+1)
 {
  if(val==a[i])
  {
   find=i;
   break;
  }
 }
 if(find>-1)  // here used -1 bcz value can be found at index 0 so 0 will be stored in var find.
 {
  printf("found value in index:%d",find);
 }
 else
 {
  printf("value not found");
 }
 getch();
}

[algorism]

Firstly, make sure you read my response to your previous post.

Think about it. How could find ever equal -1? Where do you set it to -1? (Nowhere!) Where should you set it to -1?

BTW, there's a bizarre newbie disease that causes them to put newlines at the beginning of an output string instead of at the end. You apparently have that disease. You should attempt to cure it.

main should return an int and I don't see the point of clrscr() and getch(). All that garbage just makes your code non-portable for absolutely no reason. Get rid of clrscr() and use getchar() instead of getch() (which means you'll have to hit enter instead of any key).

And you should use i++ (or ++i) instead of i = i + 1.

[Salem]

First of all, learn how to indent code. One space isn't enough. Most people go for 2 or 4 spaces.

#include<stdio.h>
int main()
{
    int i, a[60], val, find = -1;
    //clrscr();
    for (i = 0; i < 5; i = i + 1) {
        printf("\nenter value of index[%d]:", i);
        scanf("%d", &a[i]);
    }
    for (i = 0; i < 5; i = i + 1) {
        printf("\nvalue of array a[%d]:%d", i, a[i]);
    }
    printf("\nEnter value to search:");
    scanf("%d", &val);
    for (i = 0; i < 5; i = i + 1) {
        if (val == a[i]) {
            find = i;
            break;
        }
    }
    if (find > -1)              // here used -1 bcz value can be found at index 0 so 0 will be stored in var find.
    {
        printf("found value in index:%d", find);
    } else {
        printf("value not found");
    }
    //getch();
    return 0;
}

You've already been told about the void main thing, so please stop doing it.

Your find variable is uninitialised, so you need to fix that

$ ./a.out 

enter value of index[0]:2

enter value of index[1]:3

enter value of index[2]:4

enter value of index[3]:6

enter value of index[4]:8

value of array a[0]:2
value of array a[1]:3
value of array a[2]:4
value of array a[3]:6
value of array a[4]:8
Enter value to search:1
found value in index:32647$

> printf("\nEnter value to search:");
> printf("value not found");
The usual convention is to put \n at the end of every printf call to ensure that the line is seen.