Thread: If/else does not work as expected

My code:

Code:

for(int i=1; i<argc; i++)
	{
		if( (strcmp(argv[i], "--help"))==0 )
           printHelp();
		if(argv[i][0] == '-')
		{
		    for(int b=1; b<strlen(argv[i]); b++)
		    {
			    if(argv[i][b] == 'd')
			        key_d=1;
		        else if(argv[i][b] == 'c')
		            key_c=1;
	            else if(argv[i][b] == 'm')
	                key_m=1;
	            else if(argv[i][b] == 't')
	                key_t=1;
	            else if(argv[i][b] == 's')
	                key_s=1;
                else if(argv[i][b] == 'h')
                    printHelp();
                else
                {
                	printf("%c: invalid key. Use-h or --help to get help", argv[i][b]);
                    _exit(0);
                }
			}
		}

I enter test -r but I do not see the help that should be output, in the printHelp method I have the help text written about the program!
The text should be displayed after the else but it is not output! Maybe I do not know something yet?

Why would you think -r would output help? Your code looks for -h or --help.

The printf() before _exit(0) doesn't end with a newline, and the output may be line-buffered. _exit() doesn't flush I/O buffers, so the printf output is probably lost when the program terminates. I suggest two things: put a newline at the end of your printf string, and call exit(0) instead of _exit(0).

It is the newline like christop said. I see another problem though. The first if statement with the strcmp will print your help, but then it will be followed by the message "-: invalid key..."

I was too hasty and forgot to write ./ at the beginning of the team. I ran my team which I compiled and now I understand what the problem is and fixed it

No, my program produces an error

Originally Posted by Salem

> I enter test -r but I do not see the help that should be output
If you called your program 'test' and you're on a Unix/Linux system, you need to know that 'test' is also a built-in command of some shells.

test -r
Invokes the built-in command, and does nothing except set $?

./test -r
Invokes your program called test (in the current directory)

Originally Posted by algorism

Why would you think -r would output help? Your code looks for -h or --help.

Originally Posted by christophergray

It is the newline like christop said. I see another problem though. The first if statement with the strcmp will print your help, but then it will be followed by the message "-: invalid key..."

No, my program after the output of the message goes out, because the output function is specified in the function printHelp

Originally Posted by christop

The printf() before _exit(0) doesn't end with a newline, and the output may be line-buffered. _exit() doesn't flush I/O buffers, so the printf output is probably lost when the program terminates. I suggest two things: put a newline at the end of your printf string, and call exit(0) instead of _exit(0).

Yes it works fine, the problem is solved