Thread: Simple log in program

1. This is C++ code, but you posted it to the C forum.

2. Make sure your code is neatly formatted and indented:

Code:

#include <iostream.h>
#include <conio.h>

char defusername[50]="test",user[50],pass[50];
char defpassword[50]="try";

int main()
{
    cout<<"Username:";
    cin>>user;

    if(defusername == user)
        cout<<"\nEnter your password:";

    cin>>pass;

    if(defpassword == pass)
        cout<<"\nWelcome GUILDNAME to the Infinity Tower!";

    getch();

    return 0;
}

2b. Notice how much clearer the logic is when indented properly? You may want to put everything after the first "if" into a block, since currently the program will expect the password input regardless if the username is correct or not.

3. You should be using "iostream" instead of "iostream.h", and you most certainly should not be using "conio.h".

4. You should not be using global variables.

5. If you're learning C++, why are you using C-strings?

6. Don't just tell us "it isn't working", tell us how it isn't working. Is it compiling? Are there errors? Are you not getting the expected output?

If you're using C-strings (null-terminated character arrays), you can't compare strings with ==.

Out of curiosity, what language are you supposed to be learning (C or C++) and what learning material are you using?