Thread: Programming question.

When writing my code, I can get to sort my numbers as long as I list the first number to be the lowest. if I use random numbers like 1, 456,and 12 it will work but when I change them up say to 456,1,and 12 it breaks. Here is part of my code.
insert

Code:

void myfunction(double *a1, double *b1, double *c1)
{    double small, middle, large;
    if (*a1 <= *b1)
    {
    if (*a1 <= *c1)
    {
    small = *a1;
    if (*b1 <= *c1)
    {
    middle = *b1;
    large = *c1; }
    else {
    middle = *c1;
    large = *b1;
    } } }
    else
    myfunction(b1, a1, c1);
    *a1 = small;
    *b1 = middle;
    *c1 = large; }
// Unsorted and sorted numbers
void sortandprint(double a1, double b1, double c1)
{    printf("Static before numbers: %2.lf, %2.lf, %2.lf\n", a1, b1, c1);
    myfunction(&a1, &b1, &c1);
    printf("Sorted static numbers: %2.lf, %2.lf, %2.lf\n", a1, b1, c1); }
// Print and sort
int main(void)
{     sortandprint(9, 125, 789);
    system("PAUSE");
    return 0;
}

Run-Time Check Failure #3 - The variable 'small' is being used without being initialized.
Static before numbers: 72874, 44105, 25311
Sorted static numbers: -92559631349317831000000000000000000000000000000000 000000000000, -92559631349317831000000000000000000000000000000000 000000000000, -92559631349317831000000000000000000000000000000000 000000000000

It's easier if you use a swap().

Code:

if (*a1 > *c1) swap(a1, c1);
if (*a1 > *b1) swap(a1, b1);
if (*b1 > *c1) swap(b1, c1);

If you don't swap, you essentially have to code for all of the possible permutations (of which there are 6)

I need to use double per the assignment.

Then implement a swap function that uses doubles.

Unrelated to your question, you should strive for good formatting and indentation in your code. This makes it easier to read, understand, and find possible mistakes.

Originally Posted by Thermal

Code:

    } } }

Three closing braces on a single line is definitely as sign of poor formatting.

Thanks, I corrected the formatting to a better ascetically pleasing version. For the Swap double, I have never used it, so I do not know how it works. I am trying to figure it out. Sorry new to this.

How to swap two values....

declare temp variable.
set temp to value1
set value 1 to value 2
set value 2 to temp