Thread: Read in a file, reverse string, print on multiple lines base on command prompt entry

So what are you actually stuck on?

This is what I have so far...

Code:

#include <stdio.h>
#include <string.h>
#include <stdlib.h>


#define MAXC 256
int wordslength;


FILE *fname;


int main(int argc, char *argv) {
char str[MAXC];
int i;
int x;
int y;
int z;
char **words = NULL;
char buf[wordslength + 1];
int *n;
int nwords = 0;
int maxlen = MAXC > 0 ? MAXC : 1;
int rows;


fname = fopen(argv[1], "r");


while(fgets(str, wordslength + 1, fname)) {
for(x = wordslength; x >= 0; x--) {
printf("%c", str[x]);
}


printf("\n");
}


fclose(fname);
return 0;
}

Issues I am having:


1. Cannot figure out how to assign the 15 from L15 from command prompt to the wordslength variable (if that variable is being used correctly).
2. The out put is not displaying correctly. It is doubling the third line.
nworb kciuq ehT
revo spmuj xof
d dlo yzal eht
d dlo yzal
.go
4. With the above out put, words cannot be broken (example: the word 'god' (reversed for dog)).
5. I have try to research on google, and I have read something about storing previous word. Not sure how to do this.
6. I am first trying to solve the left-align issue, but then need to figure out the Center and Right-align.


I am very new to C


If any other information is needed, please just let me know.

This is wrong. You should become a warning from your compiler.

Code:

int main(int argc, char *argv) {

It should look like:

Code:

int main(int argc, char *argv[]) {

Why is the variable 'wordslength' and 'fname' global?
You can declare it in main.
And the variable 'wordslength' will be initialized to 0, because its global.
Later, you use it (on line 20) without set it to another value.
This means, your char buf[] has a size of 1 byte.
You should check if the file was successfully opened.

Code:

…
    if ((fname = fopen(argv[1], "r")) == NULL) {
        fprintf(stderr, "could not open file '%s'! exit.\n", argv[1]);
        exit(1);
    }
…

I would read the complete line and cut it in sequences.
After that, you can output every sequence in reverse order.
For middle- and right-oriented, count the characters of the sequence and output the difference as space right befor the sequence.
So, have you a sequence of 11 characters and a max length of 15:
right-oriented: output 4 space first
middle-oriented: output 2 space first

You need to step back and plan how to write the code in a series of small steps, each of which builds on previous progress.

Simply hacking away at an increasingly large main() will get you nowhere.

Eg.
Read and print all the words.

Input "The quick green owl flies over the small old cat."
Output
found word "The"
found word "quick"
found word "green"
found word "owl"
...

Until you can read words reliably, stressing over reversal and formatting is a waste of time.

Then you try say reversing the words
Input "The quick green owl flies over the small old cat."
Output
found word "ehT"
found word "kciuq"
found word "neerg"
found word "lwo"

Now think how you would break the rest of the problem down into achievable steps.
If you start a step and it seems too complicated, then break it down some more.

When your code for a given step is working, then make a copy of it so you always have something to go back to.