c program find all files in c drive

[Brahim]

i whant to program that can find all files in c:\ folder , the idea is to using linked list to store the folders and subfolders name , than using a fonction that will get the files in those folders

i have made a floder d with some subfolders in c:\ for test , when i run the program i get some symboles in floders name , any idea to how fixt it?

Target file is C:\d4☺oj♦
Target file is C:\d\k\
Target file is C:\d\pol♦
Target file is C:\d\volo\


the code is:
#include <windows.h> #include <tchar.h> #include <stdio.h> #include <string - Pastebin.com

#include <windows.h>
#include <tchar.h>
#include <stdio.h>
#include <string.h>

WIN32_FIND_DATA FindFileData;
   HANDLE hFind;
void files(HANDLE hFind,TCHAR r[]);
void onlyfiles(HANDLE hFind,TCHAR r[]);

  TCHAR pd[]="C:\\d\\";
  TCHAR z[]="*.*";
TCHAR   r[];
TCHAR   data[];

 struct node{

     
    struct node *link;
	char folder[];
  };
struct node *start = NULL;//initialiser au null
struct node *newnode;
void insertatend(struct node *start,char *data){
     struct node *p,*temp;
     temp=(struct node *)malloc(sizeof(struct node));


	strcpy(temp->folder,data);
     p=start;
    while(p->link!=NULL)
           p=p->link;
    p->link=temp;
    temp->link=NULL;
}

void displaylist(struct node *start){
 
struct node *p;
if(start==NULL)
{
  printf("list is empty\n");
  return;
}

p=start->link;

while(p!=NULL)
{          
        
		  _tprintf (TEXT("Target file is %s\n"), p->folder);
		//strcpy(r,p->folder);
		//strcat(r, "\\*.*");
	//onlyfiles(hFind,r);
	
	
    p=p->link;

		
}

	
printf("\n");
}//end of displaylist()

void _tmain()

{
	strcpy(data,pd);
  

newnode=malloc(sizeof(struct node));

	strcpy(newnode->folder,pd);
newnode->link=NULL;
start=newnode;

strcat(r, pd);
strcat(r, z);

 files(hFind,r);
	FindClose(hFind);
	displaylist(start);
	
}
void files(HANDLE hFind,TCHAR r[]){

              

hFind = FindFirstFile(r, &FindFileData);
   if (hFind == INVALID_HANDLE_VALUE) 
   {
      printf ("FindFirstFile failed (%d)\n", GetLastError());
      return;
   } 
if(FindFileData.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY && strcmp(FindFileData.cFileName, ".") != 0 && strcmp(FindFileData.cFileName, "..") != 0){
_tprintf (TEXT("The first file found is %s\n"), 
                FindFileData.cFileName);
     }
  
  while(FindNextFile(hFind, &FindFileData) != 0){
		if(FindFileData.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY && strcmp(FindFileData.cFileName, ".") != 0 && strcmp(FindFileData.cFileName, "..") != 0){
			
		strcat(data, FindFileData.cFileName);
		strcat(data, "\\");
	
	  insertatend(start,data);
			strcpy(data,pd);
	  
       
	
		}
     
		
	
	
	    }
}
void onlyfiles(HANDLE hFind,TCHAR r[]){
_tprintf (TEXT("The first file found is %s\n"), 
                r);

hFind = FindFirstFile(r, &FindFileData);
   if (hFind == INVALID_HANDLE_VALUE) 
   {
      printf ("FindFirstFile failed (%d)\n", GetLastError());
      return;
   } 
      if(strcmp(FindFileData.cFileName, ".") != 0 &&
            strcmp(FindFileData.cFileName, "..") != 0){
_tprintf (TEXT("The first file found is %s\n"), 
                FindFileData.cFileName);
     }
  
  while(FindNextFile(hFind, &FindFileData) != 0){
		if(!(FindFileData.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY) && strcmp(FindFileData.cFileName, ".") != 0 && strcmp(FindFileData.cFileName, "..") != 0){
			
		             _tprintf (TEXT("The first file found is %s\n"), 
                FindFileData.cFileName);
       
	
		}
 

    

	}
	
	
	    }

[algorism]

1. Post your code here. Be sure to use code tags.
2. Indent and space your code properly if you expect others to read it.
3. It's better to use spaces instead of tabs. You should be able to set your editor to insert 4 spaces instead of a tab character.
4. Break long lines into multiple lines.

[Salem]

My dog can indent code better than that!

> char folder[];
This doesn't magically create a char array which expands to whatever it needs to be when you try and strcpy to it.

You need to get the length of the string, then adjust the size of the malloc parameter accordingly.

[Brahim]

ok i will try it
thank u

[Brahim]

i have do that modification in insertatend fubction
temp=(struct node *)malloc(sizeof(struct node)*sizeof(struct node)); the error is gone from 3 output , their is one error
Target file is C:\d4☺[jolo
Target file is C:\d\k\
Target file is C:\d\polo\
Target file is C:\d\volo\

[Salem]

> sizeof(struct node)*sizeof(struct node)
Please explain how this measures the length of a string.

Sure, it makes the allocation a bit bigger, which is why some short strings are stored OK.

But that's not the point is it.

[Brahim]

any solution ?

[Salem]

Yes, you call strlen on the string you want to copy first, then call malloc .

[Brahim]

i have try it
len = strlen(data);
temp=(struct node *)calloc(1,len);
but i get the same error in the first folder name

[algorism]

Instead of trying random things, stop and think for a moment. You need space for the node AND the string, including the null-character at the end (which strlen doesn't count).

[Brahim]

algorism i have also do that but it dont work , i dont think is about size but i have make a directory with a big name , and his ouput was without error , the error always in the first folder name even if it is the smalest name
len = strlen(data);
temp=(struct node *)calloc(1,len+sizeof(struct node)+1);

[algorism]

Are you properly zero-terminating the string?

[Brahim]

i dont know , the string is get from a function FindNextFile

[Salem]

Perhaps post your latest formatted code.
Indent style - Wikipedia

> temp=(struct node *)calloc(1,len+sizeof(struct node)+1);
This is about right - given the code you have posted so far.

But you also have some other mistakes regarding char arrays declared with empty sizes as well.

[Brahim]

pelase tell me were is the mistakes