Thread: Problem in my code

Delete

This is the original code:

Code:

        if(LocationA == 0 && LocationB == 2){
            printf("You are on a road\n");
            if(Weapon1 = 0){

            printf("You found the sword of Reese (15dmg)\n");

            scanf(" %s", &Move);

            if(Move == 'P'){

                Sword = 15;
                (Weapon1 = 1);
                continue;
            }

        }else
        continue;
        }

I was trying to make the user pick up the Sword of Reese.

The Fix of the code was a simple =
in the

Code:

if(Weapon1 = 0)

Solution

Code:

if(Weapon1 == 0)

If you are only going to read in a single character, use
%c instead of %s. It's generally bad practice to read character
strings using scanf as there is no safe buffer overloads.

Use fgets() to read the character string and then you can further
format it using sscanf().

Sample:

Code:

char str[BUFFER];

fgets(str, sizeof(str), stdin);

Originally Posted by jimblumberg

What? The scanf() function can be safely used with C-strings as long as you use the correct width specifier to limit the number of characters retrieved.

Jim

I apologize, I worded it wrong, I did not mean to say bad practice I was
meant to say can be unsafe. Sometimes I type so fast what I think comes
out before I read it

Sorry Jim.

I think the point I am/was trying to make is that lots of people
who are new to the language perhaps do not know about the
width modifier as you mentioned.

Lots of books and tutorials do not touch on this. When I was
learning (still am) C, I was under the impression that fgets was
used for strings because it automatically allocates the size of the
maximum buffer to fit the string (sizeof) which is declared within
the character array to hold the said string.

I do understand your point of view Jim, and you are 100% correct.
It's really a matter of preference in the end. Scanf can be a very safe
function if used correctly and the programmer understands about buffer
overloads etc.

Any function, in any language, can be unsafe, unless they are designed
flawlessly.

Well my 1994 text book is going in the bin then...

Thank you Jim. Probably the most concise explained for my
poorly taught knowledge on fgets. It's a function I use lots too,
so at least now I can update my understanding to what the
function is doing under the hood.

Kudos.