hi guys im very new to c coding, really need help to make this program display "you win" when 3 characters are input...less than 3 or more than 3 should display "you lose"..please help correct me.Thanks
Code:#include<stdio.h> int main (){ int i=0; char str[8]; printf("Enter 3 characters:\n"); scanf("%s", &str[10]); if(i==0) { printf("You Lose\n"); } else printf("You Win\n"); }
Last edited by Trri Shen; 05-04-2016 at 06:01 AM.
Welcome. First, be sure your code is neatly formatted and indented - something like this:
This is wrong:Code:#include <stdio.h> int main() { int i=0; char str[8]; printf("Enter 3 characters:\n"); scanf("%s", &str[10]); if(i==0) { printf("You Lose\n"); } else printf("You Win\n"); }
You're passing the address of a non-existent element of your array. You need to pass the address of the first element, &str[0], but since an array name by itself acts as a pointer to its first element in certain contexts, this can be simplified to str.Code:scanf("%s", &str[10]);
Also, that "scanf" call is potentially dangerous since it is capable of reading and attempting to store more characters than will fit in your array. You can limit the input by including the maximum number of characters in the format string thusly: scanf("%7s", ...). Using "fgets" would be an even better way to read a string.
To determine how many characters were entered, look into the functions in "string.h".
If you do not actually need to remember the characters that were entered, you can avoid using arrays and string functions altogether.
> hi guys im very new to c coding,
You have a really awful teacher then.
> really need help to make this program display "you win" when 3 characters are input
The code is in cloud cuckoo land.
To even overwrite the i variable in the prescribed manner relies of detailed specific knowledge of how variables are laid out, and how the compiler compiles the code.
Seeing no assignment to i, the compiler is perfectly able to just reduce the final condition to
printf("You Lose\n");
since there is no legitimate way to the else clause.
If you dance barefoot on the broken glass of undefined behaviour, you've got to expect the occasional cut.
If at first you don't succeed, try writing your phone number on the exam paper.
