Thread: Delete data from struct

I assume you mean "delete an element from an array", not "delete data from a struct" (which doesn't make sense).
To remove an element from an array you need to move the latter part of the array one element-length back.

BTW, what you're calling "position" of the picture is actually called "orientation" (horizontal is landscape, vertical is portrait).

Yes i mean deleting element of array, can you give me some example how to delete element

Code:

#include <stdio.h>

int main(void) {
    int a[] = {0, 1, 2, 3, 4, 5, 6, 7, 8, 9};
    int sz = sizeof a / sizeof *a;   // number of elements in the array.

    // print array
    for (int i = 0; i < sz; i++)
        printf("%d ", a[i]);
    putchar('\n');

    // Delete element at offset 3
    for (int i = 3; i < sz - 1; i++)
        a[i] = a[i+1];
    sz--;

    // print array again
    for (int i = 0; i < sz; i++)
        printf("%d ", a[i]);
    putchar('\n');

    return 0;
}

I made this but it doesn't delete them

Code:

int delete_picture(struct picture S[],int n)
{
	int i=0;
	int z=0;
	for(i=0; i<n-1; i++)
	{
		if(S[i].size<20)
		{
			S[i].size=S[i+1].size;
			n--;
			z++;
		}
	}
	printf("Deleted pictures:%d",z);
}

The "for()" loop you have cycles through each element to find the ones that contain the desired criteria (a size of < 20).

Once such an element is found, you then need another loop to shift elements, as shown in the example by algorism.

I try that but it doesn't delete struct data for that element.

Post your code. In fact, post a simplified complete example that compiles and illustrates the problem.

Notice how algorism's example in post #4 uses a loop to shift elements. Your code is missing this.

You already have a loop to go through each element and check if a condition is found - when it is, then you need an inner loop to do the element shifting.

Can you show me how to make that inner loop for shifting ?

You have been given a concrete example in post #4. Except that, instead of starting at the arbitrary value of "3" as per that example, you want to start at the position where the condition has been found, which is "i" in your code. Note that this will require an additional indexing variable (you don't want to lose the value of "i", so you need a new index variable for shifting in the inner loop).

To get you started:

Code:

for(i=0; i<n-1; i++)
{
    if(S[i].size<20.00)
    {
        for(j=i; // ...

I try this but it doesn't work

Code:

nt delete_picture(struct picture S[],int n){
	int i=0,j=0;
	int z=0;
	for(i=0; i<n-1; i++)
	{
		if(S[i].size<20)
		{
			for(j=i;j<n; j++)
			{
			S[j].size=S[j+1].size;
			z++;
			n--;
		}
		}
	for(i=0; i<n; i++)
	{
		Print(S[i]);
	}
}

You should spend more than (literally) five minutes trying this before posting "it doesn't work".

I also note that the latest "complete" program you posted (post #9) didn't compile due to errors.

Start with a simple program that's easy to work with - strip out any unnecessary features (such as user input) so you can focus on the problem at hand.

Code:

#include <stdio.h>

struct picture {
    char name[50];
    char extension[10];
    float size;
    char location[50];
    int position;
};

void Print(struct picture S)
{
    printf("%s %s %f %s %d\n",S.name,S.extension,S.size,S.location,S.position);
}

int main(void)
{
    struct picture S[6] = {
        { "Picture-0", "png", 10.0, "C:\\pictures_0", 0 },
        { "Picture-1", "png", 20.0, "C:\\pictures_1", 1 },
        { "Picture-2", "png", 30.0, "C:\\pictures_2", 0 },
        { "Picture-3", "png", 40.0, "C:\\pictures_3", 1 },
        { "Picture-4", "png", 50.0, "C:\\pictures_4", 0 },
        { "Picture-5", "png", 60.0, "C:\\pictures_5", 1 },
    };
    int i;

    for(i = 0; i < 6; i++)
        Print(S[i]);

    return 0;
}

There, now you have simplified functional program that you experiment with. Once you get the delete function working, that function can be moved back into your main project.

Code:

S[j].size=S[j+1].size;

If you want to get rid of an entire element, you need to overwrite that element, not just a member of that element.

Code:

S[j] = S[j+1];

There are also some subtle nuances you need to observe, regarding the limit and indexing variables. A little bit of thought (and some pencil and paper to help sketch these thoughts) should help you see these.

Also, you should not be printing the array from within the delete function - try printing all values of the array in "main()" both before and after the delete function call, so you can see how the data has been changed.