Thread: help me to find out error

Code:

#include<stdio.h>
struct book
{
    char name;
    char author;
    int pages;
    float price;
};
void main()
{
    struct book b1[100];
    int i; int n;
    printf("how many books");
    scanf("%d",&n);
    for(i=0;i<n;i++)
    {
        printf("Enter name of book %d\n",i+1);

        scanf("%s",&b1[i].name);


        printf("Enter author of book %d\n",i+1);
        scanf("%s",&b1[i].author);


        printf("Enter page length of book %d\n",i+1);
        scanf("%d",&b1[i].pages);


        printf("Enter price of book %d\n",i+1);
        scanf("%f",&b1[i].price);
    }
    printf("You entered");
    for(i=0;i<n;i++)
        printf("Name %s\n author %s\n pages %d\n price %f\n",b1[i].name,b1[i].author,b1[i].pages,b1[i].price);
}

the code is wroking it accepts user inputs but "You entered" not executes. that is i want to write information what user has type
no errors in code but not showing me "you entered" information
whats wrong in last printf() statement

its not working... last printf() statemment not executes and i got program has stoped wroking error

Your structure is a bit ridiculous.

Code:

struct book
{
    char name;
    char author;
    int pages;
    float price;
};

This structure has enough space for a book with a single-letter title, and a single-letter author's name.

So the unwitting user types something in his collection and sees:

Code:

how many books2
Enter name of book 1
Where the Red Fern Grows
Enter author of book 1
Enter page length of book 1
Enter price of book 1
Enter name of book 2
Enter author of book 2
Enter page length of book 2
Enter price of book 2
You entered

And it crashes.

You need to review strings.

Code:

char title[1000];
char author[1000];

scanf("%999s %999s", title, author);

You never really know how big a string needs to be, but something is better than nothing.

thxx problem solved...i just use name[100] and author[100] at start of program and problem solved...