This program compiles but crashes at runtime. What could be wrong?
Code:///To Read and output the elements of the array using functions. #include <stdio.h> #include <stdlib.h> int i,j; Read (int array[i][j],int size) { for (i=0;i<4;i++) for(j=0;j<4;j++) { printf("Enter the\t %d,%d\t element of the array\n",i,j); scanf("%d",&array[i][j]); } } Write (int array[i][j],int size) { for (i=0;i<4;i++) for(j=0;j<4;j++) { printf(" The \t%d,%d\t element of the array is \t%d.",i,j,array[i][j]); } } main() { int arr[4][4]; Read(arr[4][4],16); Write(arr[4][4],16); }
> This program compiles but crashes at runtime. What could be wrong?
That you're ignoring errors from your compiler perhaps?
Other issuesCode:8 : error: array bound is not an integer constant before ']' token Read (int array[i][j],int size) ^ 8 : error: array bound is not an integer constant before ']' token Read (int array[i][j],int size)
- global variables
- trying to use variable sized arrays (only valid in C99)
- ignoring your size parameter
- typeless functions
To pass an array to a function, use
Read(arr,16);
When you have fixed the declaration of Read (and Write)
If you dance barefoot on the broken glass of undefined behaviour, you've got to expect the occasional cut.
If at first you don't succeed, try writing your phone number on the exam paper.
According to what I know you should define functions after the main program, and before main you should prototype them. Rest was mentioned by Salem.
It's perfectly valid to define functions before "main()" -> link.Originally Posted by nerio
Since you are using 2d array a practical use could be the prototype C99. What you are doing is just passing 16 while it's useless since you need 4 for i and 4 for j.
Code:void read(int size1,int size2,int array[][size2] // this is the prototype C99. You can put if you want size1 too, but the size2 is a must
