Thread: Help exiting program

Hey everyone! So, I have the following program. I've got it running perfectly. I realize it could be programmed cleaner or more concisely, but this is for a class and we're required to have some things in our program to ensure we're learning.

In this program you choose between being full time or part time. The program then performs calculations based on the user input. It pumps out a chunk of text that reads like:

Employee type
(1) Part time
(2) Full time
Please make selection: -1
Invalid choice, make a selection again: 2
Enter the weekly sales:12750
Commission rate is 9%
Total commission on sales is $1147.50
Net income is $1447.50.

My one problem is after each of these outputs is generated, I want to ask the user if they want to type 1 to continue, or exit. If they want to continue, it will once again prompt them if they are full time or part time employees.

I've done some research and I can't find a clear way to do it. I know I need to make a variable and perform a logical comparison test (==) to error check the user input against the number required to exit. I just can't seem to figure out where to put it.

Thanks!

Code:

#include<stdio.h>
#include<stdlib.h>


int main(void)
{


int employeeType, continueProgram;
double weeklySales, totalCommission, netIncome;


printf("Employee type \n (1)Part Time \n (2)Full Time \n");
printf("Please make a selection. \n");
scanf("%d", &employeeType);
        while(employeeType>2 || employeeType<1)
        {
                printf("Invalid choice.  Please make a selection again. \n");
                scanf("%d", &employeeType);
        }
        if(employeeType==1)
        {
                printf("Enter the weekly sales. \n");
                scanf("%lf",&weeklySales);
                if(weeklySales<=10000)
                {
                        printf("The commission rate is 7% \n");
                        totalCommission=(weeklySales*7)/100;
                        printf("Total commission on sales is $%.2f\n", totalCommission);
                        netIncome=200+(weeklySales*7)/100;
                        printf("Net income is $%.2f \n", netIncome);
                }
                if(weeklySales>10000 && weeklySales<=20000)
                {
                        printf("The commission rate is 10% \n");
                        totalCommission=(weeklySales*10)/100;
                        printf("Total commission on sales $%.2f\n", totalCommission);
                        netIncome=200+(weeklySales*10)/100;
                        printf("Net income is $%.2f \n", netIncome);
                }
        }
                if(weeklySales>20000 && weeklySales<=30000)
                {
                        printf("The commission rate is 15% \n");
                        totalCommission=(weeklySales*15)/100;
                        printf("Total commission on sales is $%.2f \n", totalCommission);
                        netIncome=200+(weeklySales*15)/100;
                        printf("Net income is $%.2f \n", netIncome);
                }
                if(weeklySales>30000 && weeklySales<=50000)
                {
                        printf("The commission rate is 17% \n");
                        totalCommission=(weeklySales*17)/100;
                        printf("Total commission on sales is $%.2f \n", totalCommission);
                        netIncome=200+(weeklySales*17)/100;
                        printf("Net income is $%.2f \n", netIncome);
                }
                if(weeklySales>50000)
                {
                        printf("The commission rate is 20% \n");
                        totalCommission=(weeklySales*20)/100;
                        printf("Total commission on sales is $%.2f \n", totalCommission);
                        netIncome=200+(weeklySales*20)/100;
                        printf("Net income is $%.2f \n", netIncome);
                }
else
        {
                printf("Enter the weekly sales. \n");
                scanf("%lf", &weeklySales);
                if(weeklySales<=10000)
                {
                        printf("The commission rate is 5% \n");
                        totalCommission=(weeklySales*5)/100;
                        printf("Total commission on sales is $%.2f \n", totalCommission);
                        netIncome=300+(weeklySales*5)/100;
                        printf("Net income is $%.2f \n", netIncome);
                }
                if(weeklySales>10000 && weeklySales<=20000)
                {
                        printf("The commission is 9% \n");
                        totalCommission=(weeklySales*9)/100;
                        printf("Total commission on sales is $%.2f \n", totalCommission);
                        netIncome=300+(weeklySales*9)/100;
                        printf("Net income is $%.2f \n", netIncome);
                }
                if(weeklySales>20000 && weeklySales<=30000)
                {
                        printf("The commission is 12% \n");
                        totalCommission=(weeklySales*12)/100;
                        printf("Total commission on sales is $%.2f \n", totalCommission);
                        netIncome=300+(weeklySales*12)/100;
                        printf("Net income is $%.2f \n", netIncome);
                }
                if(weeklySales>30000 && weeklySales<=50000)
                {
                        printf("The commission is 15% \n");
                        totalCommission=(weeklySales*15)/100;
                        printf("Total commission on sales is $%.2f \n", totalCommission);
                        netIncome=300+(weeklySales*15)/100;
                        printf("Net income is $%.2f \n", netIncome);
                }
                if(weeklySales>50000)
                {
                        printf("The commission rate is 20% \n");
                        totalCommission=(weeklySales*20)/100;
                        printf("Total commission on sales is $%.2f \n", totalCommission);
                        netIncome=300+(weeklySales*20)/100;
                        printf("Net income is $%.2f \n", netIncome);
                }
        }




}

What is considered proper indentation? I'm using Putty, and it's automatically creating the indentation and suggesting bracket placement for me. Also, the formatting of my program could have been a little messed up copying it to this forum post. But yes, my program compiles, runs, and produces valid I/O. So basically, put the while loop above my first while loop...orrrrr?

Originally Posted by Cat

Well, some hints on how this could be a lot cleaner and more concise without getting rid of what you are supposed to be learning:

1. You've near-duplicated the same block of code ten times. That's a big red flag that there's probably a better way. Think of how you could condense them - what if, rather than replicate all your printing and calculations ten times, you used one more variable - which would take values of 7, 10, 15, etc. - and setting that variable was the only thing you did in your if statements.

2. I don't know if you've covered functions, but this whole project screams for having some good separation into functions. For example, a function to return the commission rate given a sales figure and employee type would clean up main() a ton and improve readability.

I'm totally aware of functions and how this project could benefit from them, however, we're limited by a set of criteria to meet on a grading rubric. Our subsequent programs will incorporate other elements such as functions, but for now, this is the format I have to work with. It feels silly having to work like this, believe me.

Originally Posted by GReaper

Are you sure that closing bracket at line #41 should be there?

And thank you for that, I just found that error and corrected it. Believe it or not, my program still compiled and produced valid I/O even with that bracket.