Thread: Hello! Can someone help me? My code doesn't work correctly!

While I execute it 'printf("\nNota: %d", stud.nota[n]);' gives me the same result when I put differnt datas.

Code:

void afisho_lende(){
	file=fopen("lende.bin","rb");
	bin=fopen("student.bin","rb");
	
	char p_emri[20];
	char pergjigje;
	
	if(!file&&!bin)
	printf("\nU hasen probleme ne hapje");


    else{
    	printf("\nJepni emrin e lendes: ");
		scanf("%s",p_emri);
		
		int n;
		int nr_student=nrrekordesh_student(bin);
		int nr_lende=nrrekordesh_lende(file);
		
		for(int i=0;i<nr_lende;i++){
			fseek(file,sizeof(struct lendet)*i,SEEK_SET);
			fread(&lenda,sizeof(struct lendet),1,file);
			if(strcmp(p_emri,lenda.emri)==0){
			
			   printf("\n\n");
               printf("Emri: %s\n",lenda.emri);
            
          	
            for(int j=0;j<nr_student;j++){
            	n=j;
            	fseek(bin,sizeof(struct student)*j,SEEK_SET);
			    fread(&stud,sizeof(struct student),1,bin);
            	printf("\nEmri: %s",stud.emri);
            	printf("\nMbiemri: %s",stud.mbiemri);
            	printf("\nGrupi: %d", stud.grupi);
            	printf("\nNota: %d", stud.nota[n]);
            	
				   
			fclose(bin);
			fclose(file);
		}
		getchar();
			
			
			
			printf("\nShtypni p per te kerkuar nje lende tjeter");
			scanf("%c",&pergjigje);
			
			if(pergjigje=='p'||pergjigje=='P')
            afisho_lende();
		    else
		    main();
   }}
   }}

Also, why are you closing your files within the loop?

Thank You!
I have used recrusive function because it has not give me any errors.
The problem is at stud.nota[n].
While I put some different 'lenda' it gives me the same numbers exactly the numbers that I put for the first time.

And why the call to main()?

Jim

How should i close files?

Jim I call main() to execute the other part of program

Can someone help me what should I do exactly???

The function main() should never be called by any function including it's self. You should instead just return to the calling function.

Jim

Originally Posted by Eugen Hoxha

How should i close files?

You close the files when you're done with them, not when you're in the process of accessing them in a loop.
You should also check that the files have opened successfully before trying to access them.

Originally Posted by Eugen Hoxha

Jim I call main() to execute the other part of program

Here's me describing to you how to properly do this with loops, rather than calling "main()": http://cboard.cprogramming.com/c-pro...ml#post1233112

Originally Posted by Eugen Hoxha

Can someone help me what should I do exactly???

Follow the advice you've been given. If there's something you don't understand, ask for clarification.

Thank you everyone it works without a problem now!