Thread: Need help with code!

Hi guys I have to find the cubes of odd numbers between +17 to -17 using a while loop but for some reason I'm getting an infinite loop and I wonder if you guys could help me find the error.

Code:

//PROBLEM 1
//C


#include <stdio.h>
#include <math.h>


int cube(int y);  //function prototype


int main(void)
{
    int j; // inner counter


    puts("PROBLEM 2 PART (C) - CUBES OF ODD NUMBERS FROM 17 TO -17 USING WHILE LOOP:\n\n X VALUES: \t\ FACTORIAL VALUES OF X: \t\t \n\n"); // display table headers and compute square value of i


    // outer counter counting from -16 to 16
    int i = 17;
    while(i >= -17 )
    {
        i++;
        if(i % 2 == 1 || i % 2 == -1)
        {
            int factor = 1;
            j = 17;
            while (j >= i)
            {
                factor = cube(j);
                j++;


            } // end inner for


            printf("%d\t\t %d\t\t  \n\n", i, cube(i));
            }
        }
        return 0;
    }
int cube(int y)
{
    return y * y * y;
}

Code:

int i = 17;
while(i >= -17 )
{
    i++;

"i" will always be >= -17, so when do you expect this loop to end?

Note that decrementing "i" instead will have consequences on the inner "while()" loop.

I changed it but now it's not printing out anything

Post your updated code.

But first, read the last sentence of my above post and see if that leads you to the problem.

Originally Posted by Matticus

Post your updated code.

But first, read the last sentence of my above post and see if that leads you to the problem.

I tried decrementing it and it's still not showing anything

Here is the updated code:

Code:

 


//PROBLEM 1
//C


#include <stdio.h>
#include <math.h>


int cube(int y);  //function prototype


int main(void)
{
    int j; // inner counter


    puts("PROBLEM 2 PART (C) - CUBES OF ODD NUMBERS FROM 17 TO -17 USING WHILE LOOP:\n\n X VALUES: \t\ FACTORIAL VALUES OF X: \t\t \n\n"); // display table headers and compute square value of i


    // outer counter counting from 17 to -17
    int i = 17;
    while(i <= -17 )
    {
        i--;
        if(i % 2 == 1 || i % 2 == -1)
        {
            int factor = 1;
            j = 17;
            while (j <= i)
            {
                factor = cube(j);
                j++;


            } // end inner for


            printf("%d\t\t %d\t\t  \n\n", i, cube(i));
            }
        }
        return 0;
    }




int cube(int y)
{
    return y * y * y;
}

In the last code part, i starts off as 17, so it's never less than or equal to -17. So, while() never runs.

I'd suggest

Code:

for(i=-17;i<=17;i++)

Then you'd have to take a look in the inside of the for() loop.

Code:

int i = 17;
while(i <= -17 )

Well, now "i <= -17" is false from the start, so the outer loop is never executed.

---

To be honest, I'm not sure what your inner loop is supposed to be doing. You might be over-thinking your problem here.