Thread: Hello!

  1. #1
    Registered User
    Join Date
    May 2015
    Posts
    1

    Hello!

    I'm new to programming with c, and i was given an assignment in class a week ago i was wondering if anyone can give me a hint of what to do:
    The assignment was i had to enter a 4 digit int from 1000 - 9999, like 5356 and the output was suppose to be

    5 is odd
    3 is odd
    5 is odd
    6 is even


    I've written some code and i'd like to some hints and help thank you!

    Code:
    #include <stdio.h>
    #include <stdlib.h>
    
    
    
    
    int main()
    {
    
    
     int number ;
    int number1 , number2, number3, number4;
    
    
    
    
    
    
            printf("Enter your number here!:\n");
            scanf("%d", &number1, &number2, &number3, &number4) ;
    
    
    number1=       number % 10000/1000;
    number2=   number % 1000/100 ;
    number3 =     number % 100/ 10   ;
    number4 =      number % 10/1;
    
    
    printf("%d\n", number1, number2, number3, number4);
    
    
    
    
    
    
                if (number1%2==0){
                    printf("%d is even\n", number1);
    
    
                }
    
    
                else if(number1%2==1){
                printf("%d is odd\n", number1);
                }
    
    
    
    
    
    
                if (number2%2==0){
                    printf("%d is even\n", number2);
                }
                else  if(number2%2==1){
                printf("%d is odd\n", number2);
                }
    
    
    
    
    
    
                if (number3%2==0){
                    printf("%d is even\n", number3);
                }
                else if(number3%2==1){
                printf("%d is odd\n", number3);
                }
    
    
    
    
    
    
                if (number4%2==0){
                    printf("%d is even\n", number4);
                }
                else if(number4%2==1){
            printf("%d is odd\n", number4);
                }
    
    
    
    
    
    
    
    
    
    
    
    
    
    
    
    
    
    
        return 0;
    }

  2. #2
    Hurry Slowly vart's Avatar
    Join Date
    Oct 2006
    Location
    Rishon LeZion, Israel
    Posts
    6,788
    your formatting is horrible making code unreadable
    Code:
    #include <stdio.h>
    #include <stdlib.h>
    
    int main()
    {
        int number ;
        int number1 , number2, number3, number4;
    
        printf("Enter your number here!:\n");
        scanf("%d", &number1, &number2, &number3, &number4) ;
    
        number1=       number % 10000/1000;
        number2=   number % 1000/100 ;
        number3 =     number % 100/ 10   ;
        number4 =      number % 10/1;
    
        printf("%d\n", number1, number2, number3, number4);
    
        if (number1%2==0)
        {
            printf("%d is even\n", number1);
        }
        else if(number1%2==1)
        {
            printf("%d is odd\n", number1);
        }
    
        if (number2%2==0)
        {
            printf("%d is even\n", number2);
        }
        else  if(number2%2==1)
        {
            printf("%d is odd\n", number2);
        }
    
        if (number3%2==0)
        {
            printf("%d is even\n", number3);
        }
        else if(number3%2==1)
        {
            printf("%d is odd\n", number3);
        }
    
        if (number4%2==0)
        {
            printf("%d is even\n", number4);
        }
        else if(number4%2==1)
        {
            printf("%d is odd\n", number4);
        }
    
        return 0;
    }
    Use maximum warning level and fix the compilation erros
    Code:
    gcc -c -o obj/test.o src/test.c -Wall -pedantic -march=core2 -Iinclude -std=c99
    \src/test.c: In function ‘main’:
    src/test.c:10:5: warning: too many arguments for format [-Wformat-extra-args]
         scanf("%d", &number1, &number2, &number3, &number4) ;
         ^
    src/test.c:17:5: warning: too many arguments for format [-Wformat-extra-args]
         printf("%d\n", number1, number2, number3, number4);
         ^
    src/test.c:12:27: warning: ‘number’ is used uninitialized in this function [-Wuninitialized]
         number1=       number % 10000/1000;
                               ^
    All problems in computer science can be solved by another level of indirection,
    except for the problem of too many layers of indirection.
    – David J. Wheeler

Popular pages Recent additions subscribe to a feed