Thread: if statement with 2 conditions

Hi all,
I am currently trying to learn C and would appreciate any help...

Can anyone please explain why the following code will not work?
The if statement if (yn!='y' || yn!='n') always becomes true!

Code:

#include<stdio.h>

main()
{
    char yn;
    while(yn!='e') {
        printf("enter y/n? ");
        scanf(" %c", &yn);
            if (yn=='e') {
                printf("goodbye\n");
                break;
            }        

            if (yn!='y' || yn!='n') {
                printf("error, enter y or n!\n");
            }
    }
return 0;
}

I did manage to replicate the code with nested if's but after much reading it's better to write more concise code. Correct me if I am wrong?

Code:

#include<stdio.h>

main()
{
    char yn;
    while(yn!='e') {
        printf("enter y/n? ");
        scanf(" %c", &yn);
            if (yn=='e') {
                printf("goodbye\n");
                break;
            }            

            if (yn!='y') {
                if (yn!='n') {
                    printf("error, enter y or n!\n");
                }
            }
    }
return 0;
}

Hi Satya,

The while loop is simply to reiterate the program for testing. Admittedly it's me being a bit lazy. Obviously typing 'e' will exit the program.
Is my while loop not a good way to create a loop?
If not can you please provide a better example?

The if statement is within the while loop.
How is it breaking form the while loop once scanf has been done?

After thinking about your explanation about if (yn!='y' || yn!='n') you are absolutly correct, thanks.

Thank you for you help