pls help to solve the problem with this program

[Swati Sharma]

#include<stdio.h>
#include<conio.h>
int main()
{
    char name[100];
    int i=0,j=0,k=0;
    
    printf("enter the line\n");
    gets(name);
    puts(name);
    
    while(name[i]!='\0')
    {
    
    if( name[i] == "a"||name[i] == "e"||name[i] == "i"||name[i] == "o"|| name[i] == "u" )
    {
    j++;
}
    else
    {
    k++;
}
i++;
}
printf("number of vowels=%d",j);
printf("number of consonants=%d",k);


}

[laserlight]

After I removed the inclusion of <conio.h>, the program compiled. I ran the program, entering "a" as the input, and was presented with this output:

a
number of vowels=0number of consonants=1

Since you did not tell us what is the expected output, I conclude that there is nothing wrong with your program, other than:

• You should not use gets since it is unsafe. fgets could be used as an alternative, but be careful to note that it stores the newline read into the string, if it is read.
• You should indent your code more consistently.

So, you should tell us what is the purpose of your program and how does it not work. As part of this, tell us what is your test input, expected output and actual output.

[Matticus]

You should tell us how it's not working, along with warnings/error messages you receive.

Also make sure your formatting and indentation is neat and consistent; i.e.

#include<stdio.h>
//#include<conio.h>

int main()
{
    char name[100];
    int i=0,j=0,k=0;
     
    printf("enter the line\n");
    gets(name);
    puts(name);
     
    while(name[i]!='\0')
    {
        if( name[i] == "a"||name[i] == "e"||name[i] == "i"||name[i] == "o"|| name[i] == "u" )
        {
            j++;
        }
        else
        {
            k++;
        }
    
        i++;
    }

    printf("number of vowels=%d",j);
    printf("number of consonants=%d",k);
}

This line:

if( name[i] == "a"||name[i] == "e"||name[i] == "i"||name[i] == "o"|| name[i] == "u" )

Note that single characters are denoted with single quotes --> 'a'

Don't use "gets()" to read strings!

FAQ > Why gets() is bad / Buffer Overflows - Cprogramming.com
FAQ > Get a line of text from the user/keyboard (C) - Cprogramming.com

To make your code more readable, I'd suggesting giving your variables meaningful names, such as "number_of_vowels" and "number_of_consonants".

[Swati Sharma]

thanks matticus problem solved . my mistake