Thread: Can't get strings to print when using for loop.

Hello! I am making a program that takes the user's family names, their ages, and where they live. At the end I will be eventually averaging out their age and also printing the names of anyone who lives in Kansas.

I can't seem to get the Kansas part to work properly though.. When I execute the code, everything else works perfectly, but the Kansas part doesn't even print. I'm not sure exactly what I'm doing wrong. Is there something different I need to do when strings are involved rather than integers/floats? Thanks in advance!

Code:

#include <stdio.h>
int main ()
{
  /* variable definition: */
  char familyMember[60], familyMemberName[60], state[20], stateData[20];
  float userFinished=1, age, ageData[5];
  int count=0, count2=0, i, j;
   
   // Input Data
   while (userFinished > 0)
   {
    printf("Enter family member:\n");
    scanf("%s", &familyMember);
    printf("Enter age of family member:\n");
    scanf("%f", &age);
        ageData[count]=age;
        count=count+1;
    printf("Enter the state where they live:\n");
    scanf("%s", &state);
    if (state=="Texas" || state=="texas")
    {
        familyMemberName[count2];
        count2= count2 + 1;
     }
    printf("Would you like to continue entering names? Enter 1 for yes, and 0 for no\n");
    scanf("%d", &userFinished);
    } 

   // Print data
    for (j=0; j<count; j++)
    printf ("The age of your family is %f\n", ageData[j]);
   
   for (i=0; i<count2; i++)
    printf ("Family member %s was born in Texas!\n", familyMemberName[i]);
   

   return 0;
}

I haven't really look deeply at the code, but ran it and got some warnings.

Code:

/*
main.c||In function 'main':|
main.c|13|warning: format '%s' expects type 'char *', but argument 2 has type 'char (*)[60]'|
main.c|19|warning: format '%s' expects type 'char *', but argument 2 has type 'char (*)[20]'|
main.c|20|warning: comparison with string literal results in unspecified behavior|
main.c|20|warning: comparison with string literal results in unspecified behavior|
main.c|22|warning: statement with no effect|
main.c|26|warning: format '%d' expects type 'int *', but argument 2 has type 'float *'|
main.c|5|warning: unused variable 'stateData'|
||=== Build finished: 0 errors, 7 warnings ===|
*/

Did you get any of these? If not, you need to find out how to maximize your compiler warnings.

I recommend fixing these things and seeing if you get closer to a working implementation.

One thing that stuck out with the warnings:

Code:

if (state=="Texas" || state=="texas")

You can't compare strings like this in C. You need to use the "strcmp()" function from "string.h".

Originally Posted by Salem

Time being wasted over here by the cross-poster
[C] Can't Get Strings To Print When Using For Loop. Please Help&#3 - C And C++ | Dream.In.Code

Lol am I not allowed to get help from multiple sources? I don't see how that is wasting anyone's time.