Comparing each element of one array with another

[Jakub Elia]

Hi! I would like to ask you, how to compare each element of array with another,defined ? I have tried this,but didn't work.

Code:

#include <stdio.h>
#include <stdlib.h>
#include <string.h>

void bill()
{
float bill;
printf("Enter value of your bill: ");
scanf("%f",&bill);

while (bill<0 || bill>10000)
    {
    printf("Wrong input\n");
    break;
    }

}

int main()
{
char p[1000];
char val[1000];
int length = 0;
char* itr;
char notes[]={100,50,20,10,5,2,1,0.50,0.20,0.10,0.05,0.02,0.01};

bill();
while(getchar()!='\n');



fgets(p,sizeof(p),stdin); 


itr = strtok(p, " ");
while(itr!=NULL)
    {
        val[length]=atof(itr);
        itr = strtok(NULL, " ");
        length ++;
        val[length]= val[length];

    }
    
itr = strtok(p, " \n");

for(int k=0;notes[k];k++) //comparing
{
for(int i=0;i<length;i++)
    {
    if(p[i]!=notes[k])
    {
    
    printf("%c is invalid\n",p[i]);
    }
    } }

return 0;
}

Thanks for help !

[Salem]

Here are some things to think about.
1. bill() doesn't return anything.
2. bill() also has a local variable called bill. Whilst not illegal, it does lead to an awful lot of confusion.
3. notes is an array of char, yet you're trying to store floats in it.

Your indentation could be better.

You need to say what you typed in by way of user input for us to make much more sense of the code.

[Jakub Elia]

You're right. But what should bill() return? I tried local variable and 0,but compiler didn't compile it. And I typed in for example : 20 30 60 100

Here is edited code :

#include <stdio.h>
#include <stdlib.h>
#include <string.h>

void bill()
{
    float b;
    printf("Enter value of your bill: ");
    scanf("%f",&b);

    while (b<0 || b>10000)
    {
        printf("Wrong input\n");
        break;
    }
    
}

int main()
{
    char p[1000];
    char val[1000];
    int length = 0;
    char* itr;
    float notes[]={100,50,20,10,5,2,1,0.50,0.20,0.10,0.05,0.02,0.01};

    bill();
    while(getchar()!='\n');



    fgets(p,sizeof(p),stdin); 



    itr = strtok(p, " ");
    while(itr!=NULL)
    {
        val[length]=atof(itr);
        itr = strtok(NULL, " ");
        length ++;
        val[length]= val[length];

    }
    
    itr = strtok(p, " \n");
    for(int k=0;notes[k];k++)
    {
        for(int i=k+1;i<length;i++)
        {
            if(p[i]!=notes[k])
            {
    
                printf("%c is invalid\n",p[i]);
            }
        } 
    }

    return 0;
}

[Salem]

> You're right. But what should bill() return?
What did you imagine it should do when you wrote it ?

It seems to me you should be returning the input value.