Thread: Can someone help me with this simple C calculator program ?

Code:

void Calc_Sales(void)


    {char o='o';
    int ch;
    float num1,num2;
    printf("Enter operator either + or - or * or divide : \n");
    scanf(" %c", &ch);
    printf("\nEnter two operands: ");
    scanf("%f%f",&num1,&num2);
    switch(o) {
        case '+':
            printf("%.1f + %.1f = %.1f",num1, num2, num1+num2);
            break;
        case '-':
            printf("%.1f - %.1f = %.1f",num1, num2, num1-num2);
            break;
        case '*':
            printf("%.1f * %.1f = %.1f",num1, num2, num1*num2);
            break;
        case '/':
            printf("%.1f / %.1f = %.1f",num1, num2, num1/num2);
            break;
        default:
            /* If operator is other than +, -, * or /, error message is shown */
            printf("Error! operator is not correct");}
            
    


    /* Flushes input buffer */
    while ((ch = getchar()) != '\n' && ch != EOF) ;
 
    printf("\n\nPress ENTER to continue.");
    while ((ch = getchar()) != '\n' && ch != EOF);
 
    getch();
}

This is actually a part of a program, whenever i input all the required values such as the operator and the operands, it gives the following error: "Operator is not correct"

You should post the simplest, complete (i.e. compilable) program that exhibits the problem. This will allow us to compile and run the program ourselves, to help find the trouble.

This was easy enough to simply add a "main()" function to, so I took the liberty (this time).

Code:

/*
warning: format '%c' expects type 'char *', but argument 2 has type 'int *'|
*/

Note that "ch" is declared as an int.

But also, you're doing something plainly wrong:

Code:

char o='o';

// ...
printf("Enter operator either + or - or * or divide : \n");
scanf(" %c", &ch);

// ...

switch(o) {
    // ...

You read the operand into "ch", but use the variable "o" for your switch condition.

I'd also strongly advise you use more descriptive variable names. "o" and "ch" say nothing about what the variables are used for. How about naming it "operation" or some such?

Thanks a bunch guys! That solved my problem!