counting files

[bigSteve]

I would like to know of an easier way to count the number of files
(not directories) within a given folder. I have created this function but it counts both folders and files:

#include <stdio.h>
#include <dirent.h>

long file_count(char *directory)
{
DIR *dp;
long file_count=0;
struct dirent *ent;
dp = opendir(directory); // dir to open
while ( (ent = readdir(dp)) != NULL )
{
file_count++;
}

return file_count;
}

Any suggestions,

Thanks,

bigSteve

[vsriharsha]

If u are working in the DOS environment (or a DOS shell under Windows) then try the following...

#include<stdio.h>
#include<process.h>

int main()
{
FILE *fp;
int count,i;
char ch;

i=system("DIR /a-d /b >> filecnt.txt");
if(i==0)
{
fp=fopen("filecnt.txt","r");
if(fp==NULL)
{
printf("\nError Opening the Temporary File");
exit(1);
}
count=0;
while(!eof(fp))
{
ch=fgetc(fp);
if(ch=='\n')
count++;
}
printf("\n The Number of Files in the Directory is...%d",count);
}
else
{
printf("\nSYSTEM command is not working on ur system.");
}
return(0);
}

[vsriharsha]

Just forgot to close the opened file....Please add that line...

fclose(fp);

CHEERS,
Harsha.

[vsriharsha]

Just forgot to close the opened file....Please add that line...

fclose(fp);

Also. this program counts the files only in the current folder but not else where. Now, u can easily modify the program, esp the DIR statement if u want another directory.

CHEERS,
Harsha.

[Prelude]

>while(!eof(fp))
I think you meant while ( !feof ( fp ) ). Even then it's incorrect, you can search the boards for further details, it's been covered quite a bit. A better way is to declare ch as an int and do this:

while( ( ch = fgetc ( fp ) ) != EOF ) 
{  
  if ( ch == '\n' ) 
  count++; 
}

You also might consider adding code to check if the file contains data and emptying it before doing anything else. You'll notice that if you run the program several times in succession the number of files keeps increasing because you don't clear the file.

I also cut the time this program takes to run in half by declaring a buffer and using fgets instead of fgetc.

while( fgets ( buf, sizeof buf, fp ) != NULL ) 
  count++;

-Prelude

[Monster]

Ehhh, I'm not sure what compiler you are using but maybe you can use the stat function.

#include <stdio.h> 
#include <sys/stat.h>
#include <dirent.h> 

long file_count(char *directory) 
{ 
  DIR *dp;
  struct stat filestat;
  long file_count=0; 
  struct dirent *ent; 

  if((dp = opendir(directory)) == NULL) // dir to open 
    return -1;

  while ( (ent = readdir(dp)) != NULL ) 
  { 
    if(stat(dp->d_name, &filestat) >= 0) // don't know if you need the full path name
    {
      if(!(filestat.st_mode & S_IFDIR))
          file_count++; 
    }
  } 

  closedir(dp);
  return file_count; 
}

[vsriharsha]

>while(!eof(fp))
I think you meant while ( !feof ( fp ) ). Even then it's incorrect, you can search the boards for further details, it's been covered quite a bit. A better way is to declare ch as an int and do this:

code:--------------------------------------------------------------------------------
while( ( ch = fgetc ( fp ) ) != EOF )
{
if ( ch == '\n' )
count++;
}
--------------------------------------------------------------------------------

Yes, I meant eof(fp) only, but the thing is it is declared in io.h. So, need to #include it.

Good point. I missed it. U should empty it. But all that effort can be saved just by changing the dos command from

dir /a-d /b >> filecnt.txt to

dir /a-d /b > filecnt.txt


That would overwrite the file and would contain only the new list.
I thought of fgets() but just played safe....

Regards,
Sriharsha