How do I properly put char values into an array?

**eduarda2** · 10-24-2014

I'm trying to fill the array "g" with letters from the array "letras" given a certain condition. Everything is working fine, except I couldn't do it... Strange characters appear when I run the code. What am i doing wrong?

Note: This is a part of a function. "vetor" is a parameter that was passed to this function.

Code:

        int i;
	int j = 0;
	char g[20];
	char letras[5] = {'a', 'b', 'c', 'd', 'n'};
	
	while(j < g)
	{
		for(i = 0; i < 80; i = i + 4)
		{
			if(vetor[i] == 1 && vetor[i + 1] == 0 && vetor[i + 2] == 0 && vetor[i + 3] == 0)
			{
				letras[0] = g[j];
				printf("%c\n", g[j]);
				j++;
			}
			else if(vetor[i] == 0 && vetor[i + 1] == 1 && vetor[i + 2] == 0 && vetor[i + 3] == 0)
			{
				letras[1] = g[j];
				printf("%c\n", g[j]);
				j++;
			}
			else if(vetor[i] == 0 && vetor[i + 1] == 0 && vetor[i + 2] == 1 && vetor[i + 3] == 0)
			{
				letras[2] = g[j];
				printf("%c\n", g[j]);
				j++;
			}
			else if(vetor[i] == 0 && vetor[i + 1] == 0 && vetor[i + 2] == 0 && vetor[i + 3] == 1)
			{
				letras[3] = g[j];
				printf("%c\n", g[j]);
				j++;
			}
			else
			{
				letras[4] = g[j];
				printf("%c\n", g[j]);
				j++;
			}
		}
	}

**Aslaville** · 10-24-2014

Originally Posted by eduarda2

I'm trying to fill the array "g" with letters from the array "letras" given a certain condition. Everything is working fine, except I couldn't do it... Strange characters appear when I run the code. What am i doing wrong?

Note: This is a part of a function. "vetor" is a parameter that was passed to this function.

Code:

    int j = 0;
    char g[20];
    while(j < g)
    {
        for(i = 0; i < 80; i = i + 4)

Pointer comparison is undefined.

**eduarda2** · 10-24-2014

I just figured it out! i did:
ex:

Code:

g[j] = letras[0];

just put the "g" first. haha
But thanks anyway!

**c99tutorial** · 10-25-2014

Originally Posted by Aslaville

Pointer comparison is undefined.

I think you mean to say, comparing a pointer with an integer is undefined? (probably implementation defined technically). Comparing pointers with pointers should be fine. E.g. suppose you want to specify a string by a pair of pointers (no sentinel required) then you could implement string functions something like this

Code:

int countletter(char letter, const char *str, const char *strend)
{
    int p = 0;
    for (const char *s = str; s < strend; ++s)
        if (*s == letter) ++p;
    return p;
}

Thread: How do I properly put char values into an array?

Thread Tools

Search Thread

Display

How do I properly put char values into an array?

Similar Threads

How do i assign values to ponter char array????

scanning values from a char array

Indexing an Array, Based on Char Values from another.

fill unsigned char array with hex values

Comparing char values in an array using 'if'

Tags for this Thread