confused :(

[Moon River]

This program will allow the user to input string then scans the file if it contains the same string given by the user. But i always get "MATCHED" even if i enter random string. Please help. I tried and tried to place the if statement in different positions but i dont get my expected output.

#include<stdio.h>#include<stdlib.h>
#include<time.h>
#include<string.h>
int main()
{
 int found;
 char str[512];
 char string[512];
 int count=0;
 char a,b;
 do
 {


 printf("ENTER STRING: ");
 scanf("%s", &string);
 FILE *fp;
 fp=fopen("JL-answers[easy].txt", "r+");
 if (fp==NULL)
 {
  printf("ERORR.\n");
  exit(1);
 }
 while(!feof(fp))
 {
  fscanf(fp, "%s", str);
  if (strcmpi(string, str)==0)
   {
    found = 1;
   }
 }
 if (found<=1)
 {
  printf("MATCHED\n");
 }
 else
 {
  printf("STRING NOT FOUND\n");
 }
 fclose(fp);
 count++;
 }
 while(count<=15);


    
 return 0; 


}

[zub]

Why "found" uninitialized? Why it is compared in such strange way: <= 1?

[Moon River]

I did this.

int found=0;

(found=1)

But still, i dont get my expected result

[Salem]

Pick an initial value where this isn't true, regardless of what your code does.
> if (found<=1)

Better yet, try == 1

[zub]

while( fscanf(fp, "%s", str) == 1 ) {
    if( strcmpi(string, str) == 0 ) {
        found = 1;
        break;
    }
}

[Click_here]

For more info on zub's code:
FAQ > Why it's bad to use feof() to control a loop - Cprogramming.com

[laserlight]

Note that strcmpi is non-standard.

Since you declared str to be an array of 512 characters, it can store a string with a length of at most 511. Therefore, you should specify 511 as the field width when reading with fscanf and %s, e.g.,

while( fscanf(fp, "%511s", str) == 1 ) {