Help with simple BMI calculator in C

[Bponczek]

So I am fairly new to coding in general and one of my assignments was to make a working BMI calculator. I don't get any errors but when i run the program my bin.exe crashes every time I type a number in when asked "What is your height in inches". Does anyone know why this would happen or see an error in my code which I will put below? Thanks

/* My Name
 * 8.29.14
 * To calculate the BMI of the user
 */


//included libraries
#include <stdio.h>
#include <math.h>


//main function
int main() {


    //Variables
    float height,weight,BMI;


    //Ask user for data
    printf("What is your height in inches?\n", height);
    scanf("%d, &height");


    printf("What is your weight in pounds?\n", weight);
    scanf("%d, &weight");


    //bmi equation
    BMI = (weight * 703) / (height * height);
    printf("Your BMI is %.2f\n, BMI");




    return 0;
}

[Matticus]

scanf("%d, &height");

// ...

scanf("%d, &weight");

&height and &weight should not be within the quotes.

printf("Your BMI is %.2f\n, BMI");

Neither should BMI.

[Bponczek]

Thank you so much, that did the trick, now the BMI is coming out to "Your BMI is 1.#J" probably something with my equation

[Matticus]

"height" and "weight" are declared as floats. The format specifiers in your "scanf()" calls are looking for integers.

You should be getting compiler warnings about these things:

/*
main.c||In function 'main':|
main.c|22|warning: format '%d' expects type 'int *', but argument 2 has type 'float *'|
main.c|26|warning: format '%d' expects type 'int *', but argument 2 has type 'float *'|
||=== Build finished: 0 errors, 2 warnings ===|
*/

If not, read your compiler documentation to find out how to increase the warning level.

[Elkvis]

also, you should use %f in your call to scanf. %d is for int types.

[Bponczek]

Got it all working, just changed the %d to %f, thank you again

[Matticus]

You're welcome. Just FYI, it's not a good idea to edit your original post with corrections, since this makes the subsequent posts appear to make less sense. It's good that you posted the corrected code, but this should be done with a follow-up post. No big deal, though.

Oh, and welcome to the forum.