Thread: Zed Shaw Learn C The Hard Way - Extra Credit 15.3

Have print_arguments figure how long each argument string is using the strlen function, and then passthat length to print_letters.

You need to modify the print_letters() function so you can pass the length of the string into it as a parameter. You would then use this parameter in the condition section of the for(; loop.

Jim

Alternatively, examine the methodology described here: Variable Argument Lists in C and C++ - Cprogramming.com

Thank you for your responses so far.


So, I've indented the code as Tim S explained which has helped as its tidier now.


Jims suggestion was quite clear to me. I have now modified print_letters() but the compiler is now complaining that theres an "implicit declaration of function 'strlen'" but from what I've been taught I can't see where to correct that?


However, when I run the code the first printf in the for loop of print_arguments does print out the sentence " Length is 6" in this case as there're six characters in the command line instruction ./ex14. However still, Tim S also mentioned what the return function is for and I am getting the "warning: control reaches end of non-void function" …I know somethings not right here although its still not clear to me what value I need to return from print_letters for the complier not to warn me. I'm not sure if its the return function issue alone or something else I've not yet applied to have the printf in print_letters not format the data from isalpha and isblank and ultimatly have all the code perform as it should.

Once again thanks in advance!

If it can be made clear to me and where I'am going wrong can be set straight its very much appreciated, cheers!

Code:

#include <stdio.h>
#include <ctype.h>
 
 
// forward declarations
//int can_print_it(char ch);
int  print_letters(char arg[], int arglength);
 
 
void print_arguments(int argc, char *argv[])
{
     int i = 0;
     int length;
 
 
     for(i = 0; i < argc; i++)
     {
 
          length = strlen(argv[i]);  
          printf(" Length is %d\n", length);
 
 
          print_letters(argv[i], length); //does "i" arrive as "char arg"
 
     } 
}
 
 
int print_letters(char arg[], int arglength)
{
     int i = 0;


     for(i = 0; arg[i] != arglength; i++) {
          char ch = arg[i];
    
          //if(can_print_it(ch) {
          //printf(" '%c' ==%d ", ch, ch);
          return isalpha(ch) || isblank(ch) ;
          printf("'%c' == %d ", ch, ch);
     }  
 
 
     printf("\n");
    
}
 
 
 
 
// }
 
 
//int can_print_it(char ch)
//    {
//    return isalpha(ch) || isblank(ch);
//     }
 
 
int main(int argc, char *argv[])
{
     print_arguments(argc, argv);
     return 0;
}

Jims suggestion was quite clear to me. I have now modified print_letters() but the compiler is now complaining that theres an "implicit declaration of function 'strlen'" but from what I've been taught I can't see where to correct that?

You need to include the proper header file for that function, you may want to Google "strlen" and see if you can figure out what file needs to be included.

I am getting the "warning: control reaches end of non-void function"

Look at your print_letters() function, you promised the compiler that you would return an int from this function, did you? Why are you trying to return something from this function? Where are you trying to use anything returned from this function? Perhaps you shouldn't be returning anything from this function?

Do you know that there are ways to print the entire string at once, without the need for you to loop through the string and print each character?

Do you know when the program encounters a return statement the function immediately returns to the calling function, effectively stopping any loop and ignoring everything after the return?

Jim

Thanks Jim.


So I've been able to think about the return function I previously used and as you can see from the code I've made the appropriate changes, as its clear to me now that its not required for print_letters().


I get no compiling errors now. However there is one single issue I have left to understand regarding this exercise.

2. Have print_arguments figure how long each argument string is using the strlen function, and then pass that length to print_letters. Then, rewrite print_letters so it only processes this fixed length and doesn’t rely on the '\0' terminator.

I've tried this a few ways and this is what I am going with. Quite frankly I am confused but I think thats due to the fact that I am stuck for knowledge here. I've replaced '\0' with arglength but I know this is not going to work due to its value being the wrong type? Its an integer rather than a terminator character.

Does this exercise actually applying a better design, would it be more efficient without the '\0'? I can't see where to correct this. When I run the code It prints out a mess of letters…

What I've described above is my main concern but Im yet to find out how to print an entire string without the for loop which you mentioned is possible.

Code:

#include <stdio.h>
#include <ctype.h>
#include <string.h> 
 
// forward declarations
//int can_print_it(char ch);
void  print_letters(char arg[i], int arglength);
 
void print_arguments(int argc, char *argv[])
{
     int i = 0;
     int length;
 
     for(i = 0; i < argc; i++)
     {
 
          length = strlen(argv[i]);  
          printf(" Length is %d\n", length);
 
          print_letters(argv[i], length); //does "i" arrive as "char arg"
     } 
}
 
 
void print_letters(char arg[i], int arglength)
{
//     int i = 0;


     for(; arg[i] != arglength; i--) {//entire string at once without for loop?
          char ch = arg[i];
    
          if(isalpha(ch) || isblank(ch)){ 
               printf("'%c' == %d ", ch, ch);
          }
     }  
 
     printf("\n");


}
 
 
int main(int argc, char *argv[])
{
     print_arguments(argc, argv);
     return 0;
}

You need to start by fixing all your compiler errors and warnings. Here are the messages my compiler issues when compiling your code:

/home/jim/Working/c_homework/main.c|7|error: ‘i’ undeclared here (not in a function)|
/home/jim/Working/c_homework/main.c|9|warning: no previous declaration for ‘print_arguments’ [-Wmissing-declarations]|
/home/jim/Working/c_homework/main.c||In function ‘print_arguments’:|
/home/jim/Working/c_homework/main.c|20|error: type of formal parameter 1 is incomplete|
/home/jim/Working/c_homework/main.c|25|error: ‘i’ undeclared here (not in a function)|
/home/jim/Working/c_homework/main.c||In function ‘print_letters’:|
/home/jim/Working/c_homework/main.c|30|error: ‘i’ undeclared (first use in this function)|
/home/jim/Working/c_homework/main.c|30|note: each undeclared identifier is reported only once for each function it appears in|
/home/jim/Working/c_homework/main.c|25|warning: unused parameter ‘arg’ [-Wunused-parameter]|
/home/jim/Working/c_homework/main.c|9|confused by earlier errors, bailing out|
||=== Build finished: 5 errors, 2 warnings (0 minutes, 0 seconds) ===|

You really need to review your notes and your textbook for information on how to create and use functions that have arrays as parameters.

Compare your print_arguments() function implementation, which is correct, with your print_arguments() function. Look closely at the array parameter. Do you notice any difference?



Jim

I don't how I posted that code with so many compiling errors to it, that was a mistake. Well I really have got no compiling errors now!

I am doing my best.

I think I've seen the difference I needed to understand (hence no compiling errors) but when I run the code its still executes scrambled words? From the sources available to me I can't understand whats confusing to code at this late stage, beside what I explained about substituting the character null '\0' with arglength but otherwise Im kind of scrambled myself.

Code:

 

#include <stdio.h>
#include <ctype.h>
#include <string.h> 
  
// forward declarations
//int can_print_it(char ch);
void  print_letters(char arg[], int arglength);
  
void print_arguments(int argc, char *argv[])
{
     int i = 0;
     int length;
  
     for(i = 0; i < argc; i++)
     {
  
          length = strlen(argv[i]);  
          printf(" Length is %d\n", length);
  
          print_letters(argv[i], length); 
     } 
}
  
  
void print_letters(char arg[], int arglength)
{
     int i = 0;
 
 
     for( i = arglength; arg[i] != arglength; i--) { //entire string at once without for loop?
          char ch = arg[i];
     
          if(isalpha(ch) || isblank(ch)){ 
               printf("'%c' == %d ", ch, ch);
          }
     }  
  
     printf("\n");
 
 
}
  
  
int main(int argc, char *argv[])
{
     print_arguments(argc, argv);
     return 0;
}

I'm not completely sure what you're trying to accomplish, but looking at this:

Code:

for( i = arglength; arg[i] != arglength; i--)

Can you explain what you think this is doing?

(For bonus points, try printing out the value of 'i' in that loop.)

Thanks you all for your responses, I've got it now. I wanted to use strlen to get the length of the length of the command argument and use that as the comparison in the for loop, heres the working code;

Code:

#include <stdio.h>
#include <ctype.h>
#include <string.h> 
  
// forward declarations
//int can_print_it(char ch);
void  print_letters(char arg[], int arglength);
  
void print_arguments(int argc, char *argv[])
{
     int i = 0;
     int length;
  
     for(i = 0; i < argc; i++)
     {
  
          length = strlen(argv[i]);  
          printf(" Length is %d\n", length);
  
          print_letters(argv[i], length); //does "i" arrive as "char arg"
     } 
}
  
  
void print_letters(char arg[], int arglength)
{
     int i = 0;     
 
     for(i = 0; i <= arglength; i++) {//entire string at once without for loop?
          char ch = arg[i];
	
          if(isalpha(ch) || isblank(ch)){ 
               printf("'%c' == %d ", ch, ch);
          
          }
     }  
  
     printf("\n");
 
 
}
  
  
int main(int argc, char *argv[])
{
     print_arguments(argc, argv);
     return 0;
}

Very nice.

Code:

for(i = 0; i <= arglength; i++)

I would recommend changing the test condition to less-than (rather than less-than or equal-to).

For instance, if arg contains "test" (for which "strlen()" would return 4), you'd only want to print indices 0 through 3.

arg[0] == 't'
arg[1] == 'e'
arg[2] == 's'
arg[3] == 't'
arg[4] == '\0' // doesn't need to be printed