Thread: Delete all occurrences of a character

I want do delete all occurrences of a char in a given string, but I really don't see my error in the code. So I hoped someone could help me.

Here is how I did it:

Code:

  

char *input = "example_string";
int len = strlen(input);

char *new_line[len]; 
char bad = 'e'; //the one to delete    

    int i;
    int j = 0;


    for (i =0; i < len;i++) {
        char next = input[i];
      
       if (next != bad) {
        
            new_line[j] = next;  //here I get a warning : incompatible integer to pointer conversion assigning to char* from char. 



            j++;
        }  
    }

I get segmentation or bus errors..

And I also don#t understand the warning I get. new_line is an array of chars, and I am trying to assign to it a certain char.

new_line is an array of char*, which is to say an array of pointer to char. Drop the *, and you'll have an array of char.

There's one other problem: strings are terminated with a null character (which has the value zero), and you're not copying this character; strlen() does not take it into account. You'll have to copy that, too (and make sure there's space for it).

Originally Posted by cas

new_line is an array of char*, which is to say an array of pointer to char. Drop the *, and you'll have an array of char.

There's one other problem: strings are terminated with a null character (which has the value zero), and you're not copying this character; strlen() does not take it into account. You'll have to copy that, too (and make sure there's space for it).

Thank you for the advice!

And I was aware of this \0 char at the end, I usually do it this way when copying an array of chars:

Code:

char *copy_me = "example";
int l = strlen(copy_me) +1;
char *destination = (char*) malloc(sizeof(char)*l);

strncpy(destination, copy_me, l-1);

because I read somewhere, when the strings have equal length, the strncpy will add the terminal char automatically, so there I alloc for one more char, so it should be done automatically

Originally Posted by phantomotap

O_o

@Alpo: The `strdup' function is indeed common, but the function is not standard C.

Soma

I see, I usually make a note if a thing is an extension, but missed it here. Thanks.