IF Construct and Printing Strings

**ZombieXDuck** · 04-26-2014

This code i made divided a user input into characters and non character. The problem im having is that if a mixed sentence is created, such as 32B, it will only print the 'char string' and not the 'non char string'. But when the sentence is just non characters like 32 it will print the 'non-char string'. So essentially if a mixed sentences is created both of the strings won't be created or printed.(This is only a function by the way).

Code:

 
Count_chars( char Input[])
{
int i;
 for(i = 0; Input[i]; i++)
 {
	if((Input[i] <= 122) &&(Input[i] >= 97)){
	printf("Char %c\n",Input[i]);
	Char[i] = Input[i];
	}
	else{
	printf("Non-Char %c \n",Input[i]);
	NonChar[i] = Input[i];
	}
}
	printf("%s Char String\n",Char);
	printf("%s NonChar String\n",NonChar);
return;
}

**africanwizz** · 04-26-2014

i would think its a problem with your non-zero index on anything after the first run of the loop

.....
Also a string is NULL terminated

**c99tutorial** · 04-26-2014

1. What is the return type of your function?

2. Where is the definition of Char and NonChar?

3. Do you want to insert each "Char" or "Non-Char" into a new buffer? If so then you need another index counter such as j

Code:

Char[j++] = Input[i];

4. You should use isalpha to determine if a character is alphabetic rather than using magic numbers.

**Alpo** · 04-26-2014

@Africanwizz - the null termination is implied in the for loop, you don't have to explicitly state array[I] != '\0' (sort of like with other loops how you don't have to state ==true, or ==1) .

Also if it's globally declared (like I suspect this to be), it should be initialized to '\0', so you wouldn't have to append the null at the end of copy.

@Zombie-

You should specify a return type on the function.

Also, I don't know if Input[] has already had the newlines taken out, if not you will be getting an extra mysterious nonchar counted.

The problem of either nonchar or char is because I is the index of both. Lets say I put in hello123. The function correctly copies the "hello" into Char[], but by the time it is at the numbers "123", I is already 5, so it starts copying them to the 6th element of NonChar[]. You can fix this like C99 says, by adding another variable (which would start NonChar off at element 0, and copy from there.

**laserlight** · 04-26-2014

Originally Posted by Alpo

@Africanwizz - the null termination is implied in the for loop, you don't have to explicitly state array[I] != '\0' (sort of like with other loops how you don't have to state ==true, or ==1) .

I think that you misinterpreted africanwizz's statement. africanwizz implicitly observed that Char and NonChar might not be null terminated since we are not shown code that proves that they are indeed null terminated. Therefore, it is correct to suspect that they might not be null terminated, hence the printf calls using %s to print them may result in undefined behaviour.

Originally Posted by Alpo

Also if it's globally declared automatic (like I suspect this to be), it should be initialized to '\0', so you wouldn't have to append the null at the end of copy.

I think you meant to say that they are declared at file scope such that it has static storage duration. Indeed, if that were so and if the arrays are not initialised otherwise, then assuming no buffer overflow, the result will be a null terminated string. But this is not shown, and even so it is bad practice to write the code in this way, i.e., the unnecessary use of global variables and the assumption of null termination.

Thread: IF Construct and Printing Strings

Thread Tools

Search Thread

Display

IF Construct and Printing Strings

Similar Threads

Void Functions with an if else construct, not printing multiple lines.

Help printing strings

printing out strings

printing strings

printing char* strings