Thread: Sort an array alphabetically HELP!!

Hello,
I am new to C and taking a class. I need some help with an assignment.
//Build a program that uses a single-dimension array to store 10 names input by a user.
//After inputting the names, the user should see a menu with two options to sort and print the 10 names in ascending or descending order.

insert

Code:

#include <stdio.h>
#include <stdlib.h>
#include <string.h>


int main()
{
    char names[10];
    char temp[10];
    int count,i,j;
    int sort;
    count=1;
    for ((i=0);i<10;i++)
    {
        while (count<11)
        {
            printf("Please enter name %i\n",count);
            gets(names);
            count=count+1;
        }
    }
    printf("Would you like to print in Ascending (press 1) or Descending (press 2) order?\n\n");
    scanf("%d",&sort);
    if (sort==1){
        printf("\n Ascending order:\n ");
        printf("%c\n", names[i+1]);
            for (i=0;i<names-1;i++)
            {
                for (j=i+1;j<names;j++)
                {
                    if (strcmp(&names[i],&names[j])>0)
                    {
                        strcpy(&temp,&names[i]);
                        strcpy(&names[i],&names[j]);
                        strcpy(&names[j],&temp);
                    }
                }
            }
        for (i=0;i<names;i++){
                printf("\n%c\n",names[i]);
        }
    }
    else if (sort==2){
        printf("\n Descending order:\n ");
        printf("%c\n", names[i-1]);
            for (i=0;i>names ;i--)
            {
                for (j=i-1;j>names;j--)
                {
                    if (strcmp(&names[i],&names[j])>0)
                    {
                        strcpy(&temp,&names[i]);
                        strcpy(&names[i],&names[j]);
                        strcpy(&names[j],&temp);
                    }
                }
            }
        for (j=i-1; i>names; j--) {
            printf("\n%c\n",names[i]);
        }
    }
    return 0;
}

I keep

I keep getting an error i dont understand.....any advice?

How large are the names being input?

Alpo, I did not define how large the name is and I would prefer not to.

1. In that loop you keep overwriting content of the array.

Originally Posted by pabeyta

Code:

while (count<11)
{
    printf("Please enter name %i\n",count);
    gets(names);
    count=count+1;
}

2. Don't use gets as you can't control the size of the input string, use fgets instead.

3. Since the task requires the array to be single-dimension you need to create an array of pointers to char (array of strings). A block of dynamically allocated memory should be assigned to each pointer allowing to store a name from input.

Originally Posted by DRK

3. Since the task requires the array to be single-dimension you need to create an array of pointers to char (array of strings). A block of dynamically allocated memory should be assigned to each pointer allowing to store a name from input.

Too hard. Allocate an array with one dimension and address it manually.

Originally Posted by grumpy

Given that the OP hasn't demonstrated much understanding of arrays, addressing "manually" may not be any easier.

Look at line 27 in the original code. "for (i = 0; i < names-1; i++)" has all sorts of problems, given that i is an int, and names is an array of char. <shudder>.

To the OP: you really need to do back and read your introductory text and lecture notes CAREFULLY, before even trying to write more code. There are just too many problems in your code (attributable to your lack of basic understanding) that any attempt to help you would cause undue frustration - both for you and anyone trying to help. Your code has a "whack the mole" characteristic - every time one problem is fixed, another one will pop up to cause frustration.

Well "Grumpy," your name is fitting. As I previously stated, I am new to this and I am asking for help. There is no need to be pompous, if you find it too frustrating to help simply do not respond and move on but thank you anyways for your wealth of experience.

Code:

int main(){
    char names[10][10],i,j;
    char temp[10];
    int count;
    int sort;
    count=1;
    for ((i=0);i<10;i++)
    {
        while (count<11)
        {
            printf("Please enter name %i\n",count);
            scanf("%s",names);
            count=count+1;
        }
    }
    printf("Would you like to print in Ascending (press 1) or Descending (press 2) order?\n\n");
    scanf("%d",&sort);
    if (sort==1){
        printf("\n Ascending order:\n ");
        printf("%s\n",names);
    }
            else if (sort==2){
        printf("\n Descending order:\n ");
        printf("%s\n",names);
            }
            return 0;
}

Since I was having issues with the int and char change, I have since removed most of the code. So... as I said I need help getting the array to sort alphabetically, in both a ascending and descending order with the user ability to chose which is displayed. instead of using "if' and "else if" should I be using switch would this change/ help anything. Direction would be appreciated.

You are correct if I do not get my ducks in a row, it is harder to count them. I think I was able to create the code after I did more research on arrays. Thank you for the push to do so.