program error!

[[David]]

#include<stdio.h>
#include<conio.h>
main()
{
	char a, b;
	clrscr();

	printf("LATEST  NEWS \n type W for weather or S for Sports or L for local");
	scanf("%c", &a);
	
	if (a == 'W')
		{	printf("\nSunny!");
	}
	else if (a == 'L')
	{
		printf("\nMan gets head stuck in rabbit hole");
	}
	else (a == 'S')
	{
		printf("\nNo matches currently. \nPress y to check\n");
		scanf("%d",&b);
		if (b == 'y')
		printf("Don't be impatient!");
			
	}

}

I keep getting errors. Is the if...else statement wrong? If you have any ideas or answers, please help.
Thanks in advance.

[Salem]

The final else doesn't have a condition.

[[David]]

Okay, so I've changed the final else to else if but it still doesn't print "Don't be impatient " when I hit y. Is it because I used a if statement within a if... else?

[africanwizz]

Okay, so I've changed the final else to else if but it still doesn't print "Don't be impatient " when I hit y. Is it because I used a if statement within a if... else?

show code

[Elkvis]

you're telling the user to enter a letter, but you're attempting to read a number (%d) from the user. that's not going to work.

[[David]]

Gotcha thanks! Check out the updated code.

[[David]]

#include<stdio.h>
#include<conio.h>
main()
{
	char a, b,c;
	clrscr();

	printf("LATEST  NEWS \n type W for weather or S for Sports or L for local\n");
	scanf("%c", &a);
	
	if (a == 'W' || a == 'w')
		{	printf("\nSunny!");
	}
	else if (a == 'L' || a=='l')
	{
		printf("\nMan gets head stuck in rabbit hole");
	}
	else if (a == 'S' || a=='s')
	{
		printf("\nNo matches currently. \nPress y to check\n");
		scanf("%c",&b);
		if (b == 'y' || b=='Y' )
		printf("Don't be impatient!");
			
	}
	printf("\nDo you want to check the News again?(y/n)");

[jimblumberg]

You probably should add a space in front of your input to ignore any leading whitespace characters.

scanf(" %c", &b); // Note the space before the "%c".

Jim

[Kotik]

Your problem should be solved by the above answers. I just wanted to add a little extra by saying that you should probably add an else statement at the end in case the user enters a key that is "invalid".

    char a, b;    
    clrscr();


    printf("LATEST  NEWS \nType W for weather or S for Sports or L for local\n");
    scanf("%c", &a);
    getchar();


    if (a == 'W' || a == 'w')
        {   printf("\nSunny!");
    }
    else if (a == 'L' || a == 'l')
    {
        printf("\nMan gets head stuck in rabbit hole");
    }
    else if (a == 'S' || a == 's')
    {
        printf("\nNo matches currently. \nPress y to check\n");
        scanf("%c",&b);
        if (b == 'Y' || b == 'y')
            printf("Don't be impatient!");


    }
    else
        printf("Invalid input!\n");

}

This makes the program more robust because you never know what the user inputs. Its best to cover all grounds.

[[David]]

Thanks @Salem, @Elkvis, @africanwizz, @jimblumberg and @Kotik. You guys are swell! The program works just about perfect. Just one more idea to implement: I tried using a while loop to give the user a chance to repeat the program but it didn't work. I'll post the code...

[[David]]

#include<stdio.h>
#include<conio.h>
main()
{
	char a, b,c;
	clrscr();


	printf("LATEST  NEWS \n type W for weather or S for Sports or L for local\n");
	scanf("%c", &a);
	
	if (a == 'W' || a == 'w')
		{	printf("\nSunny!");
	}
	else if (a == 'L' || a=='l')
	{
		printf("\nMan gets head stuck in rabbit hole");
	}
	else if (a == 'S' || a=='s')
	{
		printf("\nNo matches currently. \nPress y to check\n");
		scanf(" %c",&b);
		if (b == 'y' || b=='Y' )
		printf("Don't be impatient! This isn't a game you know!");
			
	}
	else 
	printf("\nInvalid input!!!");
	printf("\n\nDo you want to check the News again?(y/n)\n");
	scanf(" %c",&c);

}

The last scanf is to accept input to maybe run a loop through the whole program again.

[africanwizz]

i don't see any while loops there , nevertheless i think a do-while loop will be a better option in this case. You should also take a look at this

[[David]]

Here it is:

#include<stdio.h>
#include<conio.h>
main()
{
	char a, b,c,d;
	clrscr();

do {
	

	printf("LATEST  NEWS \n type W for weather or S for Sports or L for local\n");
	scanf("%c", &a);
	
	if (a == 'W' || a == 'w')
	
		{	printf("\nSunny!");
	}
	
	else if (a == 'L' || a=='l')
	
	{
		printf("\nMan gets head stuck in rabbit hole");
	}
	
	else if (a == 'S' || a=='s')
	
	{
		printf("\nNo matches currently. \nPress y to check\n");
		scanf(" %c",&b);
		
		if (b == 'y' || b=='Y' )
		
		printf("Don't be impatient! This isn't a game you know!");
			
	}
	else 
	
	printf("\nInvalid input!!!");
	
	printf("\n\nDo you want to check the News again?(y/n)\n");
scanf(" %c",&c);
} while (c=='y' || c=='Y');

}

The variable c accepts 'y' or 'n' and the do loop runs through the block again but the value given for var c is taken for var a also and so I get "Invalid input!!! "
Is it possible to reset the var a and var c?

[anduril462]

The variable c accepts 'y' or 'n' and the do loop runs through the block again but the value given for var c is taken for var a also and so I get "Invalid input!!! "
Is it possible to reset the var a and var c?

You are misunderstanding what is happening. If you were to print a and c when it said invalid input, you would see they are not the same.

You forgot the space before the "%c" on line 12, so the newline in the input buffer after they answer Y/N to check the news again is still there, and that is what is being read into a. Add that space and it should fix it.

EDIT: Please make sure you post your code with decent indentation/formatting in the future, it makes it much easier for us to read/follow it and thus help you.

[africanwizz]

replace your line 12 with

scanf(" %c", &a);

notice the space before %c