Thread: If Else - Magic Game

magic.txt

Please solve my problem!

When i am entering single character instead of 'miz' then it is working great. But when i am using multi character like 'miz' it is showing error output. i did this program with c++ it is working but not working in c.

When i am running this program it is showing {warning] multi character constant.

Next time, please post your code in [code][/code] tags, making sure to post well-formatted code (so we can read it) and to post it as plain text (so our line numbering and syntax highlighting will work). It should look like

Code:

#include<stdio.h>
#include<string.h>

main()
{
    char a;
 
   printf("Please Enter your First Name: ");
    scanf("%s",&a);
 
   if(a=='miz')
    {
        printf("\n\aYou are awesome!");
    }
 
   else
    {
        printf("\n\aYou are not awesome!");
    }
 
   getch();
}

You should declare main to explicitly return an int, and I prefer to explicitly state no parameters (i.e. 'void' in the param list):

Code:

int main(void)

Single 'quotes' are for character literals. Double "quotes" are for string literals. You want double quotes. Also, you can't compare strings with == in C. You need to use the strcmp function.

it's not working.

Look this is very simple program. I don't need to use ' strcmp' Please tell me what's my mistake in Line 11 or solve. Write same program without error.

Please tell me what's my mistake in Line 11

Anduril already did so clearly, in post #2.

I don't need to use ' strcmp'

You're trying to compare two strings. Using a "string compare" function is clearly the best way to go. If you have a reason to disagree, please explain.

Write same program without error.

Homework policy. It is up to you to write the code. If you disregard the advice you're given, then there is little else we can do to help.

Originally Posted by Loucogame

Look this is very simple program. I don't need to use ' strcmp' Please tell me what's my mistake in Line 11 or solve. Write same program without error.

If you know so much about C, then you wouldn't need to come to us for help. But you did come to us for help. You are the novice, we are the experts (or at least, we probably know more than you). I suggest you actually listen to our advice instead of telling us we're wrong, especially when we're right. We don't like helping eople who have crappy attitudes and don't listen to the advice we give.

I already told you your mistake with line 11. Re-read my post #2.

You want to compare names. Names typically consist of multiple characters, therefore you must use a string, not a single character.

Technically you don't need to use strcmp to compare strings, but if you don't, you must implement something similar to it to check if strings are equal. You can not compare strings with == in C. Using == to compare strings does not work the way you expect it (it compares the addresses of each string, not their contents).

Note, you have another mistake too. You intend to store a string (several characters), so you must declare a variable that holds several characters. a is not such a variable. a only stores a single character. Try declaring it as an array of char. You will need to adjust your scanf too (line 9).

Homework policy

. It is up to you to write the code. If you disregard the advice you're given, then there is little else we can do to help.

This is not my homework, i'm doing for learning myself.

Originally Posted by anduril462

If you know so much about C, then you wouldn't need to come to us for help. But you did come to us for help. You are the novice, we are the experts (or at least, we probably know more than you). I suggest you actually listen to our advice instead of telling us we're wrong, especially when we're right. We don't like helping eople who have crappy attitudes and don't listen to the advice we give.

I already told you your mistake with line 11. Re-read my post #2.

You want to compare names. Names typically consist of multiple characters, therefore you must use a string, not a single character.

Technically you don't need to use strcmp to compare strings, but if you don't, you must implement something similar to it to check if strings are equal. You can not compare strings with == in C. Using == to compare strings does not work the way you expect it (it compares the addresses of each string, not their contents).

Note, you have another mistake too. You intend to store a string (several characters), so you must declare a variable that holds several characters. a is not such a variable. a only stores a single character. Try declaring it as an array of char. You will need to adjust your scanf too (line 9).

Hey why are you getting angry. I was just asking. I did this program years ago but i didn't use strcmp.That time program were running without any kind of error.
When i am using single character instead of miz then it is running. Please tell me how can i do that. This is not my homework.

Originally Posted by Loucogame

Hey why are you getting angry. I was just asking. I did this program years ago but i didn't use strcmp.That time program were running without any kind of error.
When i am using single character instead of miz then it is running. Please tell me how can i do that. This is not my homework.

I was a little angry because I told you what was wrong and you told me I was wrong and ignored my advice. It makes us feel like you're wasting our time (which we volunteer between our many other obligations).

You used C++ before. In C++ you can compare strings with ==. In C you can not. They are different languages with very different capabilities when it comes to working with strings.

A string (multiple characters in a row, like miz) is different from a single character in C. I already told you what you need if you want to compare strings. Reread my posts #2 and #7.