Thread: ascii codes!!

i have an assigment that searches a string and find the numbers of each letters written in the string and add 1 to array[26]
for instance stribg is aaaabbbb the code should add array[0] 4 and array[1] 4 i think i have to use ascii codes but i dont know how to do it?

Try this out...

int main()
{
static int array[26];
char *str;
int i;
printf("\nEnter The String: ");
gets(str);
while(*str!='\0')
{
if(*str>=65 && *str<=90)
array[*str-65]+=1;
else
if(*str >=97 && *<123)
array[*str-97]+=1;
str++;
}
clrscr();
printf("The following is the number of times each character has occured: \n);
for(i=0;i<26;i++)
{
if(array[i]>0)
printf("\n%c ==> %d Time(s)",i+65,array[i]);
}
return(0);
}

Hi vsriharsha,

Nice try but your code is not save:

Try to use fgets in stead of gets. This is more save because you can specify the lenght of your input buffer. Second, when you use gets (or fgets) you need to allocate space for your input buffer.

Code:

#include <stdio.h> 
#include <stdlib.h> 
#include <string.h>
#include <ctype.h>

int main()
{
    /* ASCII: A-Z = 65-90, a-z = 97-122 */
    char line[1024];
    char *ptr;
    int array[26];
    int i;

    memset(array, 0, 26 * sizeof(int));

    printf("Enter string\n");
    fgets(line, 1024, stdin);

    for(ptr = line; *ptr; ptr++)
        if(isalpha(*ptr))
            array[tolower(*ptr)-97] += 1;

    for(i = 0; i < 26; i++)
        printf("%c -> %d time%s\n", i+97, array[i], array[i] == 1 ? "" : "s");

    return 0;
}

Nice try but your code is not save:

Try to use fgets in stead of gets. This is more save because you can specify the lenght of your input buffer. Second, when you use gets (or fgets) you need to allocate space for your input buffer.

Is it?? Atleast I've never had any problems with gets(). Remember I'm using TURBOC (and any initializations that u insist on will be taken care of by my compiler). Secondly, I dont need to specify the length. Ur code suffers the drawback that it cannot hold more than 1024 characters, whereas the other way u can accommodate more.
If u still feel gets is a problem, then u can use scanf() safely instead...

scanf("%[^\0]s",str);

Send me an example situation where my code does not work... Remember, Portability is not my intention in the above program.

You have no problems with gets but how do you know condorx is using the same compiler? I tried your code using VC++ and I got an Access Violation on gets. Second you forget to initialize your array with zeroes. It may work with TURBO C but not on all compilers. Some compilers do not automatically initialize variables when you declare them.

An example situation? Any situation when I run it with VC++

Second you forget to initialize your array with zeroes

Thats the reason I declared my array as STATIC (which automatically initializes the array to 0's.) and I also do not claim this code to be Portable and I have no wonder knowing that it does not compile using VC++, cos it is for DOS.
:-)

Warm Regards,
Sriharsha.

So you ask someone to try something out but you don't know if it works on his/her system?

Okay, thats fine by me. But personally I always try to use generic code that works for (almost) all compilers (exept if I know which compiler that someone is using).

Cheers,
Monster

You mean like this?:

Code:

char line[1024];
int i = 0;

fgets(line, 1024, stdin);

for(i = 0; i < strlen(line); i++)
{
    if(isalpha(line[i]))
    {
    }
}

> Portability is not my intention in the above program
But what about the other portability problem - namely your 'portable' skill as a C programmer?

Sure you may not care whether any single program is portable or not, but what should really concern you is whether all your learnt experiences will travel well to other compilers, operating systems, languages etc.

Because one this is for sure, unlearning all these sloppy coding habits is going to be really hard work. Learning C is hard enough when you don't know anything - it's a lot more difficult if you've got a load of bad habits to get past.