do/while loop should end after entering the value 'N' but it does not?

[Arichardson]

#include <stdio.h>
main()
{
 float num1, num2, result;
 char choice;
 do {
  printf("Enter your first number to multiply:");
  scanf_s(" %f", &num1);
  printf("Enter your second number to multiply:");
  scanf_s(" %f", &num2);
  result = num1 * num2;
  printf("%.2f times %.2f equals %.2f\n\n", num1, num2, result);
  printf("Do you want to  enter another pair of numbers");
  printf("to multiply(Y/N): ");
  scanf_s(" %c", &choice);
} while (choice != 'N' && choice != 'n');
  return 0;
}

[anduril462]

Once again, I can't replicate the problem. Of course, if scanf_s is broken somehow, or has different behavior than you expect, well, I can't help you. As I said in your other thread, it's non-standard.

main returns an int. That means you should type

int main()

Notice the int at the beginning.

Also, as I said before, you need to provide us with the input you are giving, that is causing the problem. Copy-pasting a run from your console might be good.

[Arichardson]

Sorry new to the site not sure how everything works also new to programming!

the reason for the scanf_s is due to the fact I use Visual Studio and it doesn't seem to like the command and seems to fail until I change "scanf()" to "scanf_s()"

[tabstop]

If you're going to use scanf_s, you'll have to read the docs:

Unlike scanf and wscanf, scanf_s and wscanf_s require the buffer size to be specified for all input parameters of type c, C, s, S, or string control sets that are enclosed in []. The buffer size in characters is passed as an additional parameter immediately following the pointer to the buffer or variable.

[anduril462]

Sorry new to the site not sure how everything works also new to programming!

the reason for the scanf_s is due to the fact I use Visual Studio and it doesn't seem to like the command and seems to fail until I change "scanf()" to "scanf_s()"

This is one reason I'm not a big fan of newbies learning on VS. Microsoft has made it very clear they have no intention of following the C standard. There are ways to disable the warnings/errors you get from using scanf, but you would have to check the compiler documentation. Honestly, though, I would recommend Code::Blocks, with the default MinGW compiler, or even Pelles C (both free), as they better support the C standard.

[Salem]

Or set the VS projects up to use _CRT_SECURE_NO_DEPRECATE
c++ - Disabling Warnings generated via _CRT_SECURE_NO_DEPRECATE - Stack Overflow

[stahta01]

From scanf_s, _scanf_s_l, wscanf_s, _wscanf_s_l

The correct way to input a char is

scanf_s("%c", &c, 1);

You really need to turn on Compiler Warnings or get a Compiler that gives warnings. Because if MSVC does NOT give warnings for this it means its a PoC.

Tim S.

[migf1]

Actually, the _s family of functions introduced my Microsoft have been added as optional to the C11 standard, but with different prototypes. I think that only CLang (among the popular compilers) supports them correctly according to the latest standard. As far as I know, both gcc and pelles c do not support them at all.