Thread: Printing number patterns - need help

No worries - What have you done so far?

I see, I didnt know, sorry...
You may close/delete the thread.

Maybe this may inspire you with an idea on how you might begin. The "font" isn't usable for your program -- it's too small for a start but you might be able to trick it. How might you go about creating a "font"? Your idea probably won't look much like the code below (and that's OK), but maybe the #defines at least might give you a hint.

How might I have ended up with the code below? From the comment can you work out how to print a digit (for example the digit '5')? After that, can you work out how to print the digit sideways (hint: look up row-major on Wikipedia)?

Code:

#define FONT_W      6
#define FONT_H      6
#define GLYPH_SZ    (FONT_W * FONT_H)

/* Font data. Glyphs row-major; digits 0 to 9 sequentially (i.e. digit 1 
 * starts at index GLYPH_SZ; digitnidx = n * GLYPH_SZ where 0 <= n <= 9).
 */
static unsigned char font[] = {
    0,1,1,1,1,0,1,1,0,0,0,1,1,0,1,0,0,1,1,0,0,1,0,1,1,0,0,0,1,1,0,1,1,1,1,0,  /* Digit 0 */
    0,0,0,1,0,0,0,0,1,1,0,0,0,0,0,1,0,0,0,0,0,1,0,0,0,0,0,1,0,0,0,0,1,1,1,0,  /* Digit 1 */
    0,0,1,1,1,0,0,1,0,0,0,1,0,0,0,0,1,0,0,0,0,1,0,0,0,0,1,0,0,0,0,1,1,1,1,1,
    0,1,1,1,1,0,1,0,0,0,0,1,0,0,0,1,1,0,0,0,0,0,1,1,1,0,0,0,0,1,0,1,1,1,1,0,
    0,0,0,1,0,0,0,0,1,1,0,0,0,1,0,1,0,0,1,1,1,1,1,1,0,0,0,1,0,0,0,0,1,1,1,0,
    1,1,1,1,1,1,1,0,0,0,0,0,1,1,1,1,1,0,0,0,0,0,0,1,1,0,0,0,0,1,0,1,1,1,1,0,
    0,0,1,1,1,0,0,1,0,0,0,0,1,1,1,1,1,0,1,0,0,0,0,1,1,0,0,0,0,1,0,1,1,1,1,0,
    1,1,1,1,1,1,1,0,0,0,0,1,0,0,0,0,1,0,0,0,0,1,0,0,0,0,1,0,0,0,0,1,0,0,0,0,
    0,1,1,1,1,0,1,0,0,0,0,1,0,1,1,1,1,0,1,0,0,0,0,1,1,0,0,0,0,1,0,1,1,1,1,0,
    0,1,1,1,1,0,1,0,0,0,0,1,1,0,0,0,0,1,0,1,1,1,1,1,0,0,0,0,1,0,0,1,1,1,0,0   /* Digit 9 */
};

I forgot to mention that the code above uses a 1-dimensional array because I was hoping it might trigger you to think about how array addressing/indexing works. The following is equally valid and makes accessing the array "easier".

Code:

static unsigned char font[10][GLYPH_SZ] = {
    { 0,1,1,1,1,0,1,1,0,0,0,1,1,0,1,0,0,1,1,0,0,1,0,1,1,0,0,0,1,1,0,1,1,1,1,0 },
    { 0,0,0,1,0,0,0,0,1,1,0,0,0,0,0,1,0,0,0,0,0,1,0,0,0,0,0,1,0,0,0,0,1,1,1,0 },
    { 0,0,1,1,1,0,0,1,0,0,0,1,0,0,0,0,1,0,0,0,0,1,0,0,0,0,1,0,0,0,0,1,1,1,1,1 },
    { 0,1,1,1,1,0,1,0,0,0,0,1,0,0,0,1,1,0,0,0,0,0,1,1,1,0,0,0,0,1,0,1,1,1,1,0 },
    { 0,0,0,1,0,0,0,0,1,1,0,0,0,1,0,1,0,0,1,1,1,1,1,1,0,0,0,1,0,0,0,0,1,1,1,0 },
    { 1,1,1,1,1,1,1,0,0,0,0,0,1,1,1,1,1,0,0,0,0,0,0,1,1,0,0,0,0,1,0,1,1,1,1,0 },
    { 0,0,1,1,1,0,0,1,0,0,0,0,1,1,1,1,1,0,1,0,0,0,0,1,1,0,0,0,0,1,0,1,1,1,1,0 },
    { 1,1,1,1,1,1,1,0,0,0,0,1,0,0,0,0,1,0,0,0,0,1,0,0,0,0,1,0,0,0,0,1,0,0,0,0 },
    { 0,1,1,1,1,0,1,0,0,0,0,1,0,1,1,1,1,0,1,0,0,0,0,1,1,0,0,0,0,1,0,1,1,1,1,0 },
    { 0,1,1,1,1,0,1,0,0,0,0,1,1,0,0,0,0,1,0,1,1,1,1,1,0,0,0,0,1,0,0,1,1,1,0,0 }
};

I suppose you could also have a 3-dimensional array, although I personally wouldn't.

Hello guys,
thanks for the help.
in the end I went forward using arrays and switch-case loops.
after getting the number, I stripped it and reversed it. than on each digit I put switch case loop, witch should print the correspond function.
I need some help to call the function to print in the case ( I just don't know how...)
in addition i believe I Have lots of other rookie mistakes - appreciate the understanding and would like for any advice's, or better solution's....

Code:

#include <stdio.h>
#include <conio.h>


void zero (char array [7][17]);
   void zero (char array [7][17])
   {
    int i, j;
       char matrix[7][17]= {
                          {' ',' ','0','0','0','0','0','0','0','0','0','0','0','0','0','0','0'},
                          {' ',' ','0','0','0','0','0','0','0','0','0','0','0','0','0','0','0'},
                          {' ',' ','0','0',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ','0','0'},
                          {' ',' ','0','0',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ','0','0'},
                          {' ',' ','0','0',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ','0','0'},
                          {' ',' ','0','0','0','0','0','0','0','0','0','0','0','0','0','0','0'},
                          {' ',' ','0','0','0','0','0','0','0','0','0','0','0','0','0','0','0'},
                        };
 
    for(i = 0; i < 7; ++i)
     {
       for(j = 0; j < 17; ++j)
       printf("%c", matrix[i][j]);  
      printf("\n");
     }  
   }


void one (char array [7][17]);
   void one (char array [7][17])
   {
    int i, j;
       char matrix[7][17]= {
                          {' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' '},
                          {' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' '},
                          {' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' '},
                          {' ',' ','0','0','0','0','0','0','0','0','0','0','0','0','0','0','0'},
                          {' ',' ','0','0','0','0','0','0','0','0','0','0','0','0','0','0','0'},
                          {' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' '},
                          {' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' '},
                        };
 
    for(i = 0; i < 7; ++i)
     {
       for(j = 0; j < 17; ++j)
       printf("%c", matrix[i][j]);  
      printf("\n");
     }  
   }


void two (char array [7][17]);
   void two (char array [7][17])
   {
    int i, j;
       char matrix[7][17]= {
                          {' ',' ','0','0','0','0','0','0','0','0',' ',' ',' ',' ',' ','0','0'},
                          {' ',' ','0','0','0','0','0','0','0','0',' ',' ',' ',' ',' ','0','0'},
                          {' ',' ','0','0',' ',' ',' ',' ','0','0',' ',' ',' ',' ',' ','0','0'},
                          {' ',' ','0','0',' ',' ',' ',' ','0','0',' ',' ',' ',' ',' ','0','0'},
                          {' ',' ','0','0',' ',' ',' ',' ','0','0',' ',' ',' ',' ',' ','0','0'},
                          {' ',' ','0','0',' ',' ',' ',' ','0','0','0','0','0','0','0','0','0'},
                          {' ',' ','0','0',' ',' ',' ',' ','0','0','0','0','0','0','0','0','0'},
                        };
 
    for(i = 0; i < 7; ++i)
     {
       for(j = 0; j < 17; ++j)
       printf("%c", matrix[i][j]);  
      printf("\n");
     }  
   }


void three (char array [7][17]);
   void three (char array [7][17])
   {
    int i, j;
       char matrix[7][17]= {
                          {' ',' ','0','0',' ',' ',' ',' ','0','0',' ',' ',' ',' ',' ','0','0'},
                          {' ',' ','0','0',' ',' ',' ',' ','0','0',' ',' ',' ',' ',' ','0','0'},
                          {' ',' ','0','0',' ',' ',' ',' ','0','0',' ',' ',' ',' ',' ','0','0'},
                          {' ',' ','0','0',' ',' ',' ',' ','0','0',' ',' ',' ',' ',' ','0','0'},
                          {' ',' ','0','0',' ',' ',' ',' ','0','0',' ',' ',' ',' ',' ','0','0'},
                          {' ',' ','0','0','0','0','0','0','0','0','0','0','0','0','0','0','0'},
                          {' ',' ','0','0','0','0','0','0','0','0','0','0','0','0','0','0','0'},
                        };
 
    for(i = 0; i < 7; ++i)
     {
       for(j = 0; j < 17; ++j)
       printf("%c", matrix[i][j]);  
      printf("\n");
     }  
   }


   void four (char array [7][17]);
   void four (char array [7][17])
   {
    int i, j;
       char matrix[7][17]= {
                          {' ',' ',' ',' ',' ',' ',' ',' ','0','0','0','0','0','0','0','0','0'},
                          {' ',' ',' ',' ',' ',' ',' ',' ','0','0','0','0','0','0','0','0','0'},
                          {' ',' ',' ',' ',' ',' ',' ',' ','0','0',' ',' ',' ',' ',' ',' ',' '},
                          {' ',' ',' ',' ',' ',' ',' ',' ','0','0',' ',' ',' ',' ',' ',' ',' '},
                          {' ',' ',' ',' ',' ',' ',' ',' ','0','0',' ',' ',' ',' ',' ',' ',' '},
                          {' ',' ','0','0','0','0','0','0','0','0','0','0','0','0','0','0','0'},
                          {' ',' ','0','0','0','0','0','0','0','0','0','0','0','0','0','0','0'},
                        };
 
    for(i = 0; i < 7; ++i)
     {
       for(j = 0; j < 17; ++j)
       printf("%c", matrix[i][j]);  
      printf("\n");
     }  
   }


   void five (char array [7][17]);
   void five (char array [7][17])
   {
    int i, j;
       char matrix[7][17]= {
                          {' ',' ','0','0',' ',' ',' ',' ','0','0','0','0','0','0','0','0','0'},
                          {' ',' ','0','0',' ',' ',' ',' ','0','0','0','0','0','0','0','0','0'},
                          {' ',' ','0','0',' ',' ',' ',' ','0','0',' ',' ',' ',' ',' ','0','0'},
                          {' ',' ','0','0',' ',' ',' ',' ','0','0',' ',' ',' ',' ',' ','0','0'},
                          {' ',' ','0','0',' ',' ',' ',' ','0','0',' ',' ',' ',' ',' ','0','0'},
                          {' ',' ','0','0','0','0','0','0','0','0',' ',' ',' ',' ',' ','0','0'},
                          {' ',' ','0','0','0','0','0','0','0','0',' ',' ',' ',' ',' ','0','0'},
                        };
 
    for(i = 0; i < 7; ++i)
     {
       for(j = 0; j < 17; ++j)
       printf("%c", matrix[i][j]);  
      printf("\n");
     }  
   }


   void six (char array [7][17]);
   void six (char array [7][17])
   {
    int i, j;
       char matrix[7][17]= {
                          {' ',' ','0','0','0','0','0','0','0','0','0','0','0','0','0','0','0'},
                          {' ',' ','0','0','0','0','0','0','0','0','0','0','0','0','0','0','0'},
                          {' ',' ','0','0',' ',' ',' ',' ','0','0',' ',' ',' ',' ',' ',' ',' '},
                          {' ',' ','0','0',' ',' ',' ',' ','0','0',' ',' ',' ',' ',' ',' ',' '},
                          {' ',' ','0','0',' ',' ',' ',' ','0','0',' ',' ',' ',' ',' ',' ',' '},
                          {' ',' ','0','0','0','0','0','0','0','0',' ',' ',' ',' ',' ',' ',' '},
                          {' ',' ','0','0','0','0','0','0','0','0',' ',' ',' ',' ',' ',' ',' '},
                        };
 
    for(i = 0; i < 7; ++i)
     {
       for(j = 0; j < 17; ++j)
       printf("%c", matrix[i][j]);  
      printf("\n");
     }  
   }


   void seven (char array [7][17]);
   void seven (char array [7][17])
   {
    int i, j;
       char matrix[7][17]= {
                          {' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ','0','0'},
                          {' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ','0','0'},
                          {' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ','0','0'},
                          {' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ','0','0'},
                          {' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ','0','0'},
                          {' ',' ','0','0','0','0','0','0','0','0','0','0','0','0','0','0','0'},
                          {' ',' ','0','0','0','0','0','0','0','0','0','0','0','0','0','0','0'},
                        };
 
    for(i = 0; i < 7; ++i)
     {
       for(j = 0; j < 17; ++j)
       printf("%c", matrix[i][j]);  
      printf("\n");
     }  
   }


   void eight (char array [7][17]);
   void eight (char array [7][17])
   {
    int i, j;
       char matrix[7][17]= {
                          {' ',' ','0','0','0','0','0','0','0','0','0','0','0','0','0','0','0'},
                          {' ',' ','0','0','0','0','0','0','0','0','0','0','0','0','0','0','0'},
                          {' ',' ','0','0',' ',' ',' ',' ','0','0',' ',' ',' ',' ',' ','0','0'},
                          {' ',' ','0','0',' ',' ',' ',' ','0','0',' ',' ',' ',' ',' ','0','0'},
                          {' ',' ','0','0',' ',' ',' ',' ','0','0',' ',' ',' ',' ',' ','0','0'},
                          {' ',' ','0','0','0','0','0','0','0','0','0','0','0','0','0','0','0'},
                          {' ',' ','0','0','0','0','0','0','0','0','0','0','0','0','0','0','0'},
                        };
 
    for(i = 0; i < 7; ++i)
     {
       for(j = 0; j < 17; ++j)
       printf("%c", matrix[i][j]);  
      printf("\n");
     }  
   }


   void nine (char array [7][17]);
   void nine (char array [7][17])
   {
    int i, j;
       char matrix[7][17]= {
                          {' ',' ','0','0',' ',' ',' ',' ','0','0','0','0','0','0','0','0','0'},
                          {' ',' ','0','0',' ',' ',' ',' ','0','0','0','0','0','0','0','0','0'},
                          {' ',' ','0','0',' ',' ',' ',' ','0','0',' ',' ',' ',' ',' ','0','0'},
                          {' ',' ','0','0',' ',' ',' ',' ','0','0',' ',' ',' ',' ',' ','0','0'},
                          {' ',' ','0','0',' ',' ',' ',' ','0','0',' ',' ',' ',' ',' ','0','0'},
                          {' ',' ','0','0','0','0','0','0','0','0','0','0','0','0','0','0','0'},
                          {' ',' ','0','0','0','0','0','0','0','0','0','0','0','0','0','0','0'},
                        };
 
    for(i = 0; i < 7; ++i)
     {
       for(j = 0; j < 17; ++j)
       printf("%c", matrix[i][j]);  
      printf("\n");
     }  
   }








void main(void)
{


    long int n,rev,n1;
    int d;
    double f;
    char ch;


flushall();
printf("Enter any whole Integer Number, no bigger than 9 digits\n");
scanf_s("%lf",&f);
n=f;
while ((f!=n) || (n>99999999) || (n<0))
    {
    printf("The number you entered is not an whole Integer Number, Or bigger than 9 digits, TRY AGAIN\n");
    }

    n1=n;  
    rev=0;
      while (n!=0)
         {
         d= n%10;
         rev=rev*10+d;
         n/=10;
         } 
      while(rev!=0)
        {
         d=rev%10;
         switch(d)
        {
         case 0:
           ??????????????
           break;
         case 1:
           ??????????????
           break;
         case 2:
           ??????????????
           break;
         case 3:
           ??????????????
           break;
         case 4:
           ??????????????
           break;
         case 5:
           ??????????????
           break;
         case 6:
           ??????????????
           break;
         case 7:
           ??????????????
           break;
         case 8:
           ??????????????
           break;
         case 9:
           ??????????????
           break;
          }
         rev=rev/10;
        }

}

Don't use magic numbers, #define some constants.

What's so hard about calling a funciton? printf is a funciton, you call it just fine. All you need to do is use the function name with some parentheses and any parameters: function_name(param1, param2); But maybe it's difficult since your functions are not so well designed.

Your zero..nine functions are all basically identical, except for the local variable matrix. Whenever you have repeated code, consider making it a single function that you call from several places. Also, each of those functions takes a parameter, but you never use that parameter. Instead, consider defining those matrices outside your functions, and have a print_digit function you call, passing a different digit matrix.

Code:

#define DIGIT_WIDTH 17  // yes, this is slightly confusing, b/c the numbers are printed sideways
#define DIGIT_HEIGHT 7

char digit_0[DIGIT_HEIGHT][DIGIT_WIDTH] = {
};

void print_digit(char digit[DIGIT_HEIGHT][DIGIT_WIDTH])
{
    // similar to the contents of any of your zero..nine functions
    for (i = 0; i < DIGIT_HEIGHT; i++
        ...
}
...
d = rev % 10;
switch(d) {
    case 0:
        print_digit(digit_0);
        break;
    case 1:
        print_digit(digit_1);
        break;
...

Since the digits 0..9 map nicely to array indices, you could even do one better, and make an array of digits, i.e. a 3-d array:

Code:

#define NUM_DIGITS 10
#define DIGIT_WIDTH 17  // yes, this is slightly confusing, b/c the numbers are printed sideways
#define DIGIT_HEIGHT 7


char digits[NUM_DIGITS][DIGIT_HEIGHT][DIGIT_WIDTH] = {
    {
        {' ', ' ', '0', '0', '0'...},
        // all the ' ' and '0' for digit 0
    },
    {  // all the ' ' and '0' for digit 1
    },
    {  // all the ' ' and '0' for digit 2
    },
    ...
};



void print_digit(char digit[DIGIT_HEIGHT][DIGIT_WIDTH])
{
    // similar to the contents of any of your zero..nine functions
    for (i = 0; i < DIGIT_HEIGHT; i++
        ...
}
...
d = rev % 10;
print_digit(digits[d]);  // no switch statement needed, just the loop for processing digits