Thread: check code in function.

Hey ppl. im new to c programming and i just learnt function from my lecturer. im having trouble to find the mistake from my following codes.
It is my assignment, to create candy crush but is in number crush style.

do help me check my error. thanks

Code:

#include <stdio.h>
#include <time.h>
#include <math.h>
#include <stdlib.h>

#define rows 9
#define columns 9

void GetUsername();
void Function(int myArray[rows][columns]);



int main()

{

        printf("\n################WELCOME###############\n");
        printf("\n################NUMBER CRUSH##################\n");
        printf("\n");
                
                
        return 0;
        
}
        
        
void GetUsername()

{     

char username[30];
    
        printf("Please enter your username to login\n");
        printf("\n");
        printf("\nUsername:");
        scanf("%s", &username);
        printf("\n");
        printf("Good day, %s and best of luck in crushing the numbers", username);
        printf("\n\n");
        
        
        
    return;
    
}



    
void Function(int myArray[rows][columns])
    
 
{
int x,y;
int n;
int myArray[rows][columns];
srand(time(NULL));
    
            for(x=0; x<rows; x++)
            {
            
        
                printf("\n");
        
                    for(y=0; y<columns; y++)
                    {
                
                
                    n=rand()%9+1;
                    printf("%6i\t", n);
                    
                          /*if(myArray[rows][columns-1] || myArray[rows-1][columns])
                            
                                continue;
                                
                            else
                                break;*/
                    }
            
            
            printf("\n\n");
            
              }
        





        Function(myArray);
    
        getch();
                    
        return 0;
}                    




}

i edited some errors already. however, i didnt get myArray out in the program. Help me! thanks

Code:

#include <stdio.h>
#include <time.h>
#include <math.h>
#include <stdlib.h>

#define rows 9
#define columns 9

void GetUsername();
void Function(int myArray[rows][columns]);



int main()

{

        printf("\n################WELCOME###############\n");
        printf("\n################NUMBER CRUSH##################\n");
        printf("\n");
                
                
        return 0;
        
}
        
        
void GetUsername()

{     

char username[30];
    
        printf("Please enter your username to login\n");
        printf("\n");
        printf("\nUsername:");
        scanf("%s", &username);
        printf("\n");
        printf("Good day, %s and best of luck in crushing the numbers", username);
        printf("\n\n");
        
        
        

}



    
void Function(int myArray[rows][columns])
    
 
{
int x,y;
int n;



srand(time(NULL));
    
            for(x=0; x<rows; x++)
            {
            
        
                printf("\n");
        
                    for(y=0; y<columns; y++)
                    {
                
                
                    n=rand()%9+1;
                    printf("%6i\t", n);
                    
                          /*if(myArray[rows][columns-1] || myArray[rows-1][columns])
                            
                                continue;
                                
                            else
                                break;*/
                    }
            
            
            printf("\n\n");
            
              }
        


        Function(myArray);


        
        return;
}

Your void Function function is never ending recursion, you need a base case to stop the recursion if that is your plan. Also, username is a string, in your scanf you just need to use the name of the array and drop the '&'. The name of an array( username ) is like saying &username[0].

What's my error in it?

Code:

#include <stdio.h>
#include <time.h>
#include <math.h>
#include <stdlib.h>


#define rows 9
#define columns 9


void GetUsername(char username[]);
void Function(int myArray[rows][columns]);
char Move(myArray[rows][columns]);








int main()
{
    char username[30]; /* u nid to have this here */
    int myArray[rows][columns]; /* u nid to have this here */


    printf("\n################WELCOME###############\n");
    printf("\n################NUMBER CRUSH##################\n");
    printf("\n");
    
    GetUsername(username);     /* pass username to function */
    Function(myArray); 
    Move(myArray);      /* pass myArray to function */    
                
                
    return 0;
        
}
        
        
void GetUsername(char username[30]) /*after u pass username the function ACCEPTS 
username */
{     
    printf("Please enter your username to login\n");
    printf("\n");
    printf("\nUsername:");
    scanf("%s", username);  /* for array, dont need to use &username for scanf */
    printf("\n");
    printf("Good day, %s and best of luck in crushing the numbers", username);
    printf("\n\n");
    
    
        
}






    
void Function(int myArray[rows][columns])
{
    int x,y;
    int steps;
    int n;
        
    srand(time(NULL));
    
    for(x=0; x<rows; x++)
    {
        printf("\n");
        
        for(y=0; y<columns; y++)
        {
            n=rand()%9+1;
            printf("%6i\t", n);
        
                          /*if(myArray[rows][columns-1] || myArray[rows-1][columns])
                            
                                continue;
                                
                            else
                                break;*/
        }
        
            printf("\n\n");
            
        }
      
      
      if(steps>0)
      printf("\n%i Step taken", steps);
      printf("\n\n");
      printf("Press 2 - Down\n");
      printf("Press 4 - Left\n");
      printf("Press 6 - Right\n");
      printf("Press 8 - Up\n");
      printf("Press Q to give up\n");
      
      }
      
char move(myArray[rows][columns])
{
    char move;


    do
    {
        fflush(stdin);
        move = getche();
            
        if(move == '2')
            down(myArray);    /*execute down function*/
            
        if(move == '4')    
            left(myArray);    /*execute left function*/
            
        if(move == '6')    
            right(myArray);    /*execute right function*/
            
        if(move == '8')    
            up(myArray);    /*execute up function*/
                        
        if(move == 'q')    
            quit();    /*execute quit in game function*/
            
        if(move == 'Q')
            quit();    /*execute quit in game function*/
            
    }while(move != '2' && move != '4' && move != '6' && move != '8');
}

You have to give that array a type (look at the two lines above it).

What's that cat on your task bar?

That's a quincy icon, the software i used for programming my first year. haha

Oh ya, how careless i am. Thanks for that man! do i need to declare the left, right, up and down?

Originally Posted by Xian Yao

Oh ya, how careless i am. Thanks for that man! do i need to declare the left, right, up and down?

If you expect those to be function calls, then yes you need to write (and declare) the functions.

Noted. Thanks man!