file problem

[slyer4ever]

HII!
i have to create a file "family.TXT" whose the informations are structured by this way:
Family name
Father's name
Mother's name
Number of children
Names of children

i attempt this code it works until i type "Number of children" it display an error message

#include <stdio.h>#include <stdlib.h>
#include <string.h>
typedef struct
    {
    char n_family[20];
    char n_father [20];
    char n_mother [20];
    int nbr_enf;
    char n_child[20];
    }family;
    family nbr[20];
int main(int argc, char *argv[])
{
  int k=0;
FILE * fichier=NULL;
fichier=fopen("w","family.TXT");
 if (fichier != NULL)
    {
      printf("there is a problem \n");
        fclose(fichier);
    }
    printf("family name :");
    printf("\n");
    scanf(" %s",&nbr[k].n_family);
    printf("father's name :");
    printf("\n");
    scanf(" %s",&nbr[k].n_father);
    printf("mother's name:");
    printf("\n");
    scanf(" %s",&nbr[k].n_mother);
    printf("Number of children");
    printf("\n");
    scanf(" %d",&nbr[k].nbr_enf);
    fprintf(fichier,"%s\n%s\n%s\n%d\n",nbr[k].n_family,nbr[k].n_father,nbr[k].n_mother,nbr[k].nbr_enf);
    fclose(fichier);

[vart]

What error message?

Also for %s format you should remove & since array name is converted to pointer automatically

Also note - that if you succeed in opening the file - you close it and then try to output into the closed handle

If you fail to open the file - you still output into the NULL pointer

Both operations should fail

[slyer4ever]

it's a memory message error "0x7c91100b"

[oogabooga]

You probably shouldn't be mixing English and French in your code. Best to stick with English if you're asking for help from a bunch of English speakers! (I'm thinking of your use of "fichier" instead "file" and "enf", presumably meaning "enfants", instead of "children".)


And what does "nbr" mean? I thought "number", but it doesn't make sense since you call your entire family array nbr. And why are all the family struct members prefixed with n_ ? What does that mean?


Now the logic. You'll should exit the program if the file doesn't open (and you shouldn't attempt to close it).


There's no reason to print the \n character with a separate printf.


You shouldn't put the ampersand & in front of string members. They are already pointers, so the & is incorrect there. That's the problem you're having.

[slyer4ever]

yes i'm sorry for the confusion
I have solved the problem thank you guys

[ovi420]

there is no problem